Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix conversion of microseconds in test #14706

Closed
wants to merge 1 commit into from
Closed

test: fix conversion of microseconds in test #14706

wants to merge 1 commit into from

Conversation

nickstanish
Copy link
Contributor

Fixes: #8728

Changes the conversion for process cpuUsage test

Checklist
Affected core subsystem(s)

process

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 9, 2017
Trott
Trott approved these changes Aug 9, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Trott
Copy link
Member

Trott commented Aug 9, 2017

Hi, @nickstanish! Welcome, and thanks for the contribution!

Small change to the commit message (and I guess this PR title too): The subsystem here is test rather than process. So that should be the first word (before the colon) of the commit message and PR title. No big deal if it doesn't happen--whoever lands the PR can do it, but if you want to save them a few keystrokes, that would be great.

@Trott
Copy link
Member

Trott commented Aug 9, 2017

Pummel tests don't get run in Ci so only the linter results are relevant, but here's a CI run anyway...

CI: https://ci.nodejs.org/job/node-test-pull-request/9565/

CI has not been having a good week, but we should be able to get some linter results at least. :-D

@nickstanish nickstanish changed the title process: fix conversion of microseconds in test test: fix conversion of microseconds in test Aug 9, 2017
@nickstanish nickstanish force-pushed the fix-process-cpuusage-test branch from 7989ff7 to d0621a6 Compare August 9, 2017 05:03
@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Aug 9, 2017
@nickstanish nickstanish mentioned this pull request Aug 9, 2017
Closed
@pmuellr
Copy link

pmuellr commented Aug 9, 2017

thanks @nickstanish !!! LGTM

@Trott
Copy link
Member

Trott commented Aug 10, 2017

CI is good (only failure is a known issue unrelated to this).

Given the small nature of the change, the low risk (it's a test modification, and easy to revert if it turns out there is an unforeseen problem), and the copious approvals, I'm going to land this now rather than waiting the full 48 hours.

Trott pushed a commit to Trott/io.js that referenced this pull request Aug 10, 2017
@nickstanish @Trott
test: fix conversion of microseconds in test
a439cf4 
PR-URL: nodejs#14706
Fixes: nodejs#8728
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@Trott
Copy link
Member

Trott commented Aug 10, 2017

Landed in a439cf4.

Thanks for the contribution! 🎉

@Trott Trott closed this Aug 10, 2017
addaleax pushed a commit that referenced this pull request Aug 10, 2017
@nickstanish @addaleax
test: fix conversion of microseconds in test
06ba2da 
PR-URL: #14706
Fixes: #8728
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@addaleax addaleax mentioned this pull request Aug 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
@nickstanish @MylesBorins
test: fix conversion of microseconds in test
9d84641 
PR-URL: #14706
Fixes: #8728
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process.cpuUsage accuracy
10 participants
@nickstanish @Trott @pmuellr @lpinca @TimothyGu @cjihrig @tniessen @mscdex @MylesBorins @nodejs-github-bot