Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test-benchmark-arrays #14728

Closed
wants to merge 1 commit into from
Closed

test: add test-benchmark-arrays #14728

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 10, 2017

Add minimal test to confirm that arrays benchmarks run.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark

@Trott
test: add test-benchmark-arrays
00a2132 
Add minimal test to confirm that arrays benchmarks run.
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. labels Aug 10, 2017
@Trott
Copy link
Member Author

Trott commented Aug 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9608/

@Trott
Copy link
Member Author

Trott commented Aug 12, 2017

Landed in 7253eae

@Trott Trott closed this Aug 12, 2017
Trott added a commit to Trott/io.js that referenced this pull request Aug 12, 2017
@Trott
test: add test-benchmark-arrays
7253eae 
Add minimal test to confirm that arrays benchmarks run.

PR-URL: nodejs#14728
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
addaleax pushed a commit that referenced this pull request Aug 13, 2017
@Trott @addaleax
test: add test-benchmark-arrays
82c63a5 
Add minimal test to confirm that arrays benchmarks run.

PR-URL: #14728
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@addaleax addaleax mentioned this pull request Aug 13, 2017
Merged
@targos targos mentioned this pull request Sep 3, 2017
Closed
@MylesBorins
Copy link
Contributor

run.js doesn't exist on v6.x

@Trott Trott deleted the test-benchmark-arrays branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @MylesBorins @danbev @jasnell @cjihrig @hiroppy @gibfahn