Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: fix [kInspect]() output for Http2Stream #14753

Merged
merged 1 commit into from
Aug 14, 2017
Merged

http2: fix [kInspect]() output for Http2Stream #14753

merged 1 commit into from
Aug 14, 2017

Conversation

evanlucas
Copy link
Contributor

@evanlucas evanlucas commented Aug 10, 2017 •
edited
Loading

This fixes a typo in the util.inspect output of Http2Stream. It previously had
writeableSate instead of writableState.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Aug 10, 2017
@evanlucas evanlucas force-pushed the writeableStatehttp2 branch from 3c32056 to 85e3dd3 Compare August 10, 2017 22:09
@evanlucas
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9649/

@evanlucas
http2: fix [kInspect]() output for Http2Stream
b2a9b81 
This fixes a typo in the util.inspect output of Http2Stream. It
previously had writeableSate instead of writableState.

PR-URL: nodejs#14753
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@evanlucas evanlucas force-pushed the writeableStatehttp2 branch from 85e3dd3 to b2a9b81 Compare August 14, 2017 15:10
@evanlucas evanlucas closed this Aug 14, 2017
@evanlucas evanlucas deleted the writeableStatehttp2 branch August 14, 2017 15:10
@evanlucas
Copy link
Contributor Author

Landed in b2a9b81. Thanks!

@evanlucas evanlucas merged commit b2a9b81 into nodejs:master Aug 14, 2017
addaleax pushed a commit that referenced this pull request Aug 14, 2017
@evanlucas @addaleax
http2: fix [kInspect]() output for Http2Stream
1d40850 
This fixes a typo in the util.inspect output of Http2Stream. It
previously had writeableSate instead of writableState.

PR-URL: #14753
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@addaleax addaleax mentioned this pull request Aug 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@evanlucas @jasnell @addaleax @lpinca @TimothyGu @cjihrig @MylesBorins @nodejs-github-bot