Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: correct assert benchmark #14799

Closed
wants to merge 1 commit into from
Closed

benchmark: correct assert benchmark #14799

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 13, 2017

benchmark/assert/deepequal-buffer.js benchmarks assert.deepEqual()
if the method option is strict and assert.deepStrictEqual() if
method is nonstrict. That seems backwards and an error. This commit
fixes it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

@Trott
benchmark: correct assert benchmark
55b6073 
`benchmark/assert/deepequal-buffer.js` benchmarks `assert.deepEqual()`
if the `method` option is `strict` and `assert.deepStrictEqual()` if
`method` is `nonstrict`. That seems backwards and an error. This commit
fixes it.
@Trott Trott added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 13, 2017
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Aug 13, 2017
@refack
Copy link
Contributor

refack commented Aug 13, 2017

I think #14147 just made this obsolete, sorry.

@refack refack closed this Aug 13, 2017
@Trott Trott deleted the correct-assert-bench branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @refack @lpinca @cjihrig @gibfahn @nodejs-github-bot