Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x backport] Repl: do not consider ... as a REPL command #14915

Closed
wants to merge 76 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
2a9e9d4
tools: use no-use-before-define ESLint rule
vsemozhetbyt Jul 1, 2017
7b53be0
test: fix flaky test-https-set-timeout-server
Trott Jul 8, 2017
d35e5c7
test: fix flaky http(s)-set-server-timeout tests
Trott Jul 20, 2017
194836f
v8: handle proxy objects in MakeMirror(), v1
bnoordhuis Jul 24, 2017
5a93c16
v8: handle proxy objects in MakeMirror(), v2
bnoordhuis Jul 24, 2017
ae3e7be
v8: fix RegExp nits in v8_prof_polyfill.js
vsemozhetbyt Jun 15, 2017
c96e938
tools: update to ESLint 4.1.0
Trott Jun 24, 2017
58e0c5c
tools: add script to update ESLint
Trott Jun 24, 2017
05ee559
tools: update to ESLint 4.1.1
Trott Jun 27, 2017
175d46e
test: skip test-fs-readdir-ucs2 if no support
Trott Jul 1, 2017
9320db0
tools: remove align-multiline-assignment lint rule
Trott Jul 5, 2017
e8c0e0f
lib: use consistent indentation for ternaries
Trott Jul 5, 2017
5e6c711
lib: remove excess indentation
Trott Jul 5, 2017
a75ba80
lib: normalize indentation in parentheses
Trott Jul 7, 2017
5ef17b7
lib: update indentation of ternaries
Trott Jul 15, 2017
b0f8bc9
test: adjust indentation for stricter linting
Trott Jul 25, 2017
5f7827d
doc: fix indentation issues in sample code
Trott Jun 27, 2017
f46e14c
tools: remove legacy indentation linting
Trott Aug 15, 2017
e0f8b18
src: remove GTEST_DONT_DEFINE_ASSERT_EQ in util.h
danbev Apr 25, 2017
44d3047
test: simplify test skipping
vsemozhetbyt Jun 30, 2017
162bc81
build,windows: implement PEP514 python detection
refack Jun 24, 2017
970fe59
build,windows: restore DISTTYPEDIR
refack Jun 28, 2017
1b9563a
build,win: fix python detection script
jasongin Jul 31, 2017
124d5e1
tools: generate template literal for addon tests
Trott Jul 5, 2017
f868b75
doc,test: fs - reserved characters under win32
XadillaX Jul 4, 2017
7a1ff59
doc: fix mistake in http.md
galeo Jul 7, 2017
6624a02
doc: note 'resize' event conditions on Windows
Dean-Coakley Jun 9, 2017
584f0f4
doc: correct stream Duplex allowHalfOpen doc
Trott Jul 7, 2017
5c3fd35
test: add get/set effective uid/gid tests
evanlucas Jul 5, 2017
3bd0c7c
test: remove common.noop
Trott May 4, 2017
ec68f07
tools: update ESLint to 4.2.0
Trott Aug 16, 2017
f395b48
tools: update package.json `engine` field
strugee Jul 12, 2017
98466c5
doc: update umask for clarity
jsumners Jul 11, 2017
b646c2a
benchmark: fix typo in inspect-proxy
vsemozhetbyt Jul 14, 2017
b89e806
test: fix flaky test-net-can-reset-timeout
Trott Jul 15, 2017
ed6d4f0
test: check complete error message
fraserxu Jul 16, 2017
b64fe2e
test: use regular expression to match error msg
Amunu Jul 16, 2017
a71e23a
test: use regluar expression in vm test
AkiraXue Jul 16, 2017
49312cb
test: use regexp to confir error message
bangwu Jul 16, 2017
d462267
test: simplify string concatenation
jiangplus Jul 16, 2017
a4281c6
test: use template literal for string concat
whatwewant Jul 16, 2017
f84a7a6
test: use regex error checks in test-util-format
superwoods Jul 16, 2017
41e4e46
doc: move LTS README link to increase prominence
gibfahn Jul 16, 2017
5303db7
http: OutgoingMessage change writable after end
Kasher Jun 30, 2017
01d7d30
gyp: implement LD/LDXX for ninja and FIPS
sam-github Jul 13, 2017
2039435
test: check error with regex in test-signal-safety
shaman2009 Jul 16, 2017
3148bc7
test: use regex error check in test-crypto-random
f48vj Jul 16, 2017
1e10f9f
test: fix error handling test-http-full-response
Trott Jul 15, 2017
3be54c8
test: replace concatenation with template literals
csvwolf Jul 16, 2017
1a8bf8a
doc,stream: _transform happens one at a time
mcollina Jul 17, 2017
1703871
doc: replace dead link in v8 module
drboyer Jul 19, 2017
028f650
docs: add note about fs.rmdir()
Oleksandr-Kushchak-i2 Jul 17, 2017
49662f3
build,tools: do not force codesign prefix
evanlucas Jul 12, 2017
1209832
build: codesign tarball binary on macOS
evanlucas Jul 12, 2017
bc1d4c5
test: use path.join for long path concatenation
jankjn Jul 16, 2017
b21a42d
doc: add XadillaX to collaborators
XadillaX Jul 20, 2017
9aa4a5b
test: replace string concatenation with template
Jul 16, 2017
6e08ae0
test: replace concatenation with template literals
leizongmin Jul 16, 2017
c3bb07c
doc: describe labelling process for backports
addaleax Apr 15, 2017
6e65501
deps: cherry-pick 18ea996 from c-ares upstream
addaleax Jul 15, 2017
ad86c26
doc: update experimental status to reflect use
jasnell Apr 28, 2017
fd5d6c9
test: replace concatenation with template literal
HSUCHING Jul 16, 2017
cdcec0c
test: replace concatenation with template literal
rockcoder23 Jul 16, 2017
b9a5253
test: fix flaky test-force-repl
Trott Jul 23, 2017
baa11a1
test: improve error logging for inspector test
Trott Jul 27, 2017
7c542ab
buffer: remove a wrongly added attribute specifier
hujiajie Jul 24, 2017
1232d9d
linkedlist: correct grammar in comments
alexbostock Jul 30, 2017
9132f37
test: add check on an addon that does not register
ezequielgarcia Jun 28, 2017
435ab00
test: refactor test-vm-new-script-new-context
Trott Jul 29, 2017
014a9bd
test: refactor test-domain-abort-on-uncaught
Trott Jul 30, 2017
071018e
src: use existing strings over creating new ones
addaleax Aug 2, 2017
403c465
doc: add gabrielschulhof to collaborators
Aug 8, 2017
567acf6
tools: update to ESLint 4.3.0
Trott Jul 21, 2017
1e07864
repl: do not consider `...` as a REPL command
shivanth Jul 23, 2017
4aa1af7
Revert as per comments
shivanth Aug 22, 2017
9b28ab8
fix else position
shivanth Aug 22, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use regular expression to match error msg
PR-URL: #14265
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Amunu authored and MylesBorins committed Aug 16, 2017
commit b64fe2e9dbb911e95cca8fb8c6581a748dc21a47
2 changes: 1 addition & 1 deletion test/parallel/test-stream-writable-null.js
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@ MyWritable.prototype._write = function(chunk, encoding, callback) {
assert.throws(() => {
const m = new MyWritable({objectMode: true});
m.write(null, (err) => assert.ok(err));
}, TypeError, 'May not write null values to stream');
}, /^TypeError: May not write null values to stream$/);
assert.doesNotThrow(() => {
const m = new MyWritable({objectMode: true}).on('error', (e) => {
assert.ok(e);