Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2,doc: added link definitions to footer in http2.md #14946

Closed
wants to merge 4 commits into from
Closed

http2,doc: added link definitions to footer in http2.md #14946

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e04feca
http2,doc: added links definition for Class:http2.Server and Class:ht…
sharababy Aug 17, 2017
83f2b5a
http2,doc: added all link definitions to footer
sharababy Aug 17, 2017
8b67046
http2,doc: fixed link definitions in footer
sharababy Aug 17, 2017
bec28d6
http2,doc:Sorted the links definition block in ASCIIbetical order.
Aug 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2598,3 +2598,16 @@ if the stream is closed.
[Readable Stream]: stream.html#stream_class_stream_readable
[`ServerRequest`]: #http2_class_server_request
[`stream.pushStream()`]: #http2_stream-pushstream
[`http2.Server`]: #http2_class_http2server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🥇
While you are here it would be nice if you could sort the whole definition block in "ASCIIbetical" order.

[`http2.SecureServer`]: #http2_class_http2secureserver
[`request.socket.getPeerCertificate()`]: tls.html#tls_tlssocket_getpeercertificate_detailed
[Writable Stream]: stream.html#stream_writable_streams
[`EventEmitter`]: events.html#events_class_eventemitter
[`response.end()`]: #http2_response_end_data_encoding_callback
[`response.socket`]: #http2_response_socket
[`TypeError`]: errors.html#errors_class_typeerror
[`response.write(data, encoding)`]: http.html#http_response_write_chunk_encoding_callback
[`response.write()`]: #http2_response_write_chunk_encoding_callback
[`response.setHeader()`]: #http2_response_setheader_name_value
[`response.writeHead()`]: #http2_response_writehead_statuscode_statusmessage_headers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: could you remove the extra line at the end (try to keep a single \n at the end of the file)