Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused parameters #14968

Closed
wants to merge 1 commit into from
Closed

test: remove unused parameters #14968

wants to merge 1 commit into from

Conversation

human33
Copy link
Contributor

@human33 human33 commented Aug 21, 2017

Removed the unused arguments of functions defined in
test/addons-napi/test_async/test.js
test/addons-napi/test_typedarray/test.js
test/addons/repl-domain-abort/test.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Aug 21, 2017
Trott
Trott approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending a good CI run.

@Trott
Copy link
Member

Trott commented Aug 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9779/

jasnell pushed a commit that referenced this pull request Aug 23, 2017
@human33 @jasnell
test: remove unused parameters
6c382de 
PR-URL: #14968
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 23, 2017

Landed in 6c382de

@jasnell jasnell closed this Aug 23, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
@human33 @addaleax
test: remove unused parameters
bad346a 
PR-URL: nodejs/node#14968
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
@human33 @addaleax
test: remove unused parameters
d277c86 
PR-URL: nodejs/node#14968
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@human33 @MylesBorins
test: remove unused parameters
94b850f 
PR-URL: #14968
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@human33 @MylesBorins
test: remove unused parameters
36b8b46 
PR-URL: #14968
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@human33
test: remove unused parameters
6ec485a 
PR-URL: nodejs#14968
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@human33 @MylesBorins
test: remove unused parameters
31c9717 
Backport-PR-URL: #19447
PR-URL: #14968
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Kunal Pathak <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Cai <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@human33 @Trott @jasnell @danbev @lpinca @cjihrig @hiroppy @DavidCai1111 @kunalspathak @nodejs-github-bot