Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] benchmark: var to const #15511

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] benchmark: var to const #15511

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Sep 20, 2017 •
edited
Loading

Ref: #13757

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. child_process Issues and PRs related to the child_process subsystem. cluster Issues and PRs related to the cluster subsystem. crypto Issues and PRs related to the crypto subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. domain Issues and PRs related to the domain subsystem. v8 engine Issues and PRs related to the V8 dependency. v8.x labels Sep 20, 2017
@lpinca
Copy link
Member

lpinca commented Sep 21, 2017 •
edited
Loading

zlib benchmarks are new so maybe it's better to move them to a separate commit/PR?

@jasnell
Copy link
Member

jasnell commented Sep 21, 2017

This is showing a conflict :-/

@jasnell
Copy link
Member

jasnell commented Sep 21, 2017

Also, can you go ahead and squash the commits. Will make landing it easier. Thank you!

@BridgeAR
benchmark: var to const
eb62d55 
PR-URL: nodejs#13757
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BridgeAR BridgeAR force-pushed the backport-13757-to-v8.x branch from 8306e9f to eb62d55 Compare September 21, 2017 15:17
@BridgeAR
Copy link
Member Author

Rebased.

@jasnell
Copy link
Member

jasnell commented Sep 21, 2017

Landed in v8.x-staging

@jasnell jasnell closed this Sep 21, 2017
@BridgeAR BridgeAR deleted the backport-13757-to-v8.x branch April 1, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. child_process Issues and PRs related to the child_process subsystem. cluster Issues and PRs related to the cluster subsystem. crypto Issues and PRs related to the crypto subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. domain Issues and PRs related to the domain subsystem. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BridgeAR @lpinca @jasnell @nodejs-github-bot