Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace string concatenation in test file #15915

Closed
wants to merge 1 commit into from
Closed

test: replace string concatenation in test file #15915

wants to merge 1 commit into from

Conversation

robtpaton
Copy link
Contributor

This was a task from Code & Learn at NINA17.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@robtpaton
test: replace string concatenation in test-http-incoming-pipelined-so…
270da6d 
…cket-destroy

This was a task from Code & Learn at NINA17.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@robtpaton
Copy link
Contributor Author

Saw an error while running tests:

Error: test_callback_abort at ActivityCollector.initHooks.oninit.common.mustCall (/Users/patonr02/workspace/node/test/async-hooks/test-callback-error.js:36:45)

but this is unrelated to my change, and according to a mentor may have something to do with my OS (OSX Yosemite 10.10.5)

@watilde
Copy link
Contributor

watilde commented Oct 6, 2017 •
edited
Loading

Let's see the test results on ci then.
ci: https://ci.nodejs.org/job/node-test-pull-request/10419/

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@BridgeAR BridgeAR self-assigned this Oct 9, 2017
BridgeAR pushed a commit that referenced this pull request Oct 9, 2017
@robtpaton @BridgeAR
test: replace string concatenation with template
66a990b 
PR-URL: #15915
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 9, 2017

Landed in 66a990b

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@robtpaton @MylesBorins
test: replace string concatenation with template
2d25a3b 
PR-URL: #15915
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@robtpaton @addaleax
test: replace string concatenation with template
9889c74 
PR-URL: nodejs/node#15915
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@robtpaton @MylesBorins
test: replace string concatenation with template
06519b8 
PR-URL: #15915
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
@robtpaton @MylesBorins
test: replace string concatenation with template
1aac70f 
PR-URL: #15915
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@robtpaton @MylesBorins
test: replace string concatenation with template
4243903 
PR-URL: #15915
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees

@BridgeAR BridgeAR

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@robtpaton @watilde @BridgeAR @benjamingr @cjihrig @tniessen @mscdex @MylesBorins @Trott @nodejs-github-bot