doc: add managing multiple builds section to benchmarking guide #16142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Fishrock123
previously requested changes
Oct 19, 2017
| @@ -163,6 +163,20 @@ First build two versions of Node.js, one from the master branch (here called | |||
| `./node-master`) and another with the pull request applied (here called | |||
| `./node-pr-5134`). | |||
|
|
|||
| *To run multiple compiled versions paralell you need to copy the output of the | |||
There was a problem hiding this comment.
Spelling: parallel, also maybe put an in before parallel.
hekike
force-pushed
the
docs/guide-writing-and-running-benchmarks-multiple-builds
branch
from
90e5d17 to
cb9fe06
Compare
|
@Fishrock123 thanks, fixed! |
apapirovski
approved these changes
Oct 26, 2017
| @@ -163,6 +163,20 @@ First build two versions of Node.js, one from the master branch (here called | |||
| `./node-master`) and another with the pull request applied (here called | |||
| `./node-pr-5134`). | |||
|
|
|||
| *To run multiple compiled versions in parallel you need to copy the output of the | |||
There was a problem hiding this comment.
Could this not be italics? I think it flows well with the rest of the copy here so it doesn't need to stand out.
| @@ -163,6 +163,20 @@ First build two versions of Node.js, one from the master branch (here called | |||
| `./node-master`) and another with the pull request applied (here called | |||
| `./node-pr-5134`). | |||
|
|
|||
| *To run multiple compiled versions in parallel you need to copy the output of the | |||
| build: `cp ./out/Release/node ./node-master`. | |||
| Check out the following example:* | |||
There was a problem hiding this comment.
Maybe remove the linebreak before this.
|
@Fishrock123 Would you mind reviewing this as it appears your feedback has been addressed? |
hekike
force-pushed
the
docs/guide-writing-and-running-benchmarks-multiple-builds
branch
from
cb9fe06 to
776ac9c
Compare
|
@apapirovski thanks, fixed! |
jasnell
approved these changes
Oct 26, 2017
|
CI: https://ci.nodejs.org/job/node-test-pull-request/11007/ (just for all the linting & markdown checking, will stop after that job) |
apapirovski
pushed a commit
that referenced
this pull request
Oct 27, 2017
PR-URL: #16142 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #16142 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
PR-URL: #16142 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
PR-URL: #16142 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16142 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16142 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16142 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)