Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: use module name macro #16185

Closed
wants to merge 2 commits into from
Closed

n-api: use module name macro #16185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4a86c2
n-api: use module name macro
mhdawson Oct 13, 2017
a01b564
squash: address comments
mhdawson Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/addons-napi/test_warning/test_warning.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ napi_value Init(napi_env env, napi_value exports) {
return result;
}

NAPI_MODULE(test_warning, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons-napi/test_warning/test_warning2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ napi_value Init(napi_env env, napi_value exports) {
return result;
}

NAPI_MODULE(test_warning2, Init)
NAPI_MODULE(NODE_GYP_MODULE_NAME, Init)
2 changes: 1 addition & 1 deletion test/addons/callback-scope/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ void Initialize(v8::Local<v8::Object> exports) {

} // namespace

NODE_MODULE(binding, Initialize)
NODE_MODULE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/dlopen-ping-pong/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ void init(Local<Object> exports) {
NODE_SET_METHOD(exports, "ping", Ping);
}

NODE_MODULE(binding, init)
NODE_MODULE(NODE_GYP_MODULE_NAME, init)

} // anonymous namespace

Expand Down
2 changes: 1 addition & 1 deletion test/addons/node-module-version/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ inline void Initialize(v8::Local<v8::Object> exports,

}

NODE_MODULE_CONTEXT_AWARE(binding, Initialize)
NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/openssl-binding/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ inline void Initialize(v8::Local<v8::Object> exports,

} // anonymous namespace

NODE_MODULE_CONTEXT_AWARE(binding, Initialize)
NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/addons/zlib-binding/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ inline void Initialize(v8::Local<v8::Object> exports,

} // anonymous namespace

NODE_MODULE_CONTEXT_AWARE(binding, Initialize)
NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
2 changes: 1 addition & 1 deletion test/gc/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,4 @@ inline void Initialize(v8::Local<v8::Object> exports,

} // anonymous namespace

NODE_MODULE_CONTEXT_AWARE(binding, Initialize)
NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)