Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add license information for remark-cli #16637

Closed
wants to merge 1 commit into from
Closed

doc: add license information for remark-cli #16637

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

The LICENSE file was not originally included when remark-cli was
vendored. This Commit adds the LICENSE file back to tools/remark-cli
and updates the top level license in the project

@MylesBorins
doc: add license information for remark-cli
9b8878b 
The LICENSE file was not originally included when remark-cli was
vendored. This Commit adds the LICENSE file back to tools/remark-cli
and updates the top level license in the project
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Oct 31, 2017
@MylesBorins
Copy link
Contributor Author

I'd like to have this fast tracked.

v8.x and v9.x should not be released without this or we would be in violation of the license of remark-cli

ping @gibfahn and @jasnell

This was referenced Oct 31, 2017
Closed
Merged
Merged
@maclover7
Copy link
Contributor

Should this be documented somewhere, maybe the collaborator guide? 😬

@joyeecheung
Copy link
Member

@maclover7 Yeah...I am thinking Introducing new dependencies like this one https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#introducing-new-modules

@joyeecheung joyeecheung mentioned this pull request Oct 31, 2017
Closed
@gibfahn gibfahn self-assigned this Oct 31, 2017
@gibfahn
Copy link
Member

gibfahn commented Oct 31, 2017

Landing...

@gibfahn
Copy link
Member

gibfahn commented Oct 31, 2017

Landed in c396fbf

@gibfahn gibfahn closed this Oct 31, 2017
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@MylesBorins @gibfahn
doc: add license information for remark-cli
c396fbf 
The LICENSE file was not originally included when remark-cli was
vendored. This Commit adds the LICENSE file back to tools/remark-cli
and updates the top level license in the project

PR-URL: #16637
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@MylesBorins @gibfahn
doc: add license information for remark-cli
3454c82 
The LICENSE file was not originally included when remark-cli was
vendored. This Commit adds the LICENSE file back to tools/remark-cli
and updates the top level license in the project

PR-URL: #16637
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@gibfahn
Copy link
Member

gibfahn commented Oct 31, 2017

Backported to v8.x-staging in 3454c82 (confirmed that if you reset LICENSE and run the script again it generates an identical license).

@jasnell
Copy link
Member

jasnell commented Oct 31, 2017

cherry-picked into v9.x-staging now.

jasnell pushed a commit that referenced this pull request Oct 31, 2017
@MylesBorins @jasnell
doc: add license information for remark-cli
decb9e7 
The LICENSE file was not originally included when remark-cli was
vendored. This Commit adds the LICENSE file back to tools/remark-cli
and updates the top level license in the project

PR-URL: #16637
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@refack
Copy link
Contributor

refack commented Oct 31, 2017 •
edited
Loading

Not objecting, on the contrary I strongly believe that credit should be given even beyond the term of the license, and @wooorm deserve credit for this great tool.
But AFAICT the use of remank-cli does not require a license change. This is just a script to automatically use the tool, it does not make the tool part of the node.js software.
If we follow the assumption that we need to explicitly give attribution to any and all tools we use during our build (even those who are cached in the repo) we will need to explicitly acknowledge all the dependencies and all the node_modeules in the repo, and to all the compilers and and testing tools we use as well as to Jenkins and all its plugins etc.

Who can we ask for a more educated opinion than my layman's view?

@gibfahn
Copy link
Member

gibfahn commented Nov 1, 2017

Who can we ask for a more educated opinion than my layman's view?

I think that's something that has to go to the foundation via @MylesBorins

@refack refack mentioned this pull request Nov 1, 2017
Closed
2 tasks
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@MylesBorins @Qard
doc: add license information for remark-cli
06b9b16 
The LICENSE file was not originally included when remark-cli was
vendored. This Commit adds the LICENSE file back to tools/remark-cli
and updates the top level license in the project

PR-URL: nodejs/node#16637
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@MylesBorins @Qard
doc: add license information for remark-cli
ba52c6d 
The LICENSE file was not originally included when remark-cli was
vendored. This Commit adds the LICENSE file back to tools/remark-cli
and updates the top level license in the project

PR-URL: nodejs/node#16637
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins deleted the remark-cli-license branch November 14, 2017 17:44
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@MylesBorins @addaleax
doc: add license information for remark-cli
9421fb2 
The LICENSE file was not originally included when remark-cli was
vendored. This Commit adds the LICENSE file back to tools/remark-cli
and updates the top level license in the project

PR-URL: nodejs/node#16637
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label Dec 20, 2017
@MylesBorins MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees

@gibfahn gibfahn

Labels
meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.