Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9.1.0 proposal #16851

Merged
merged 99 commits into from
Nov 7, 2017
Merged

v9.1.0 proposal #16851

merged 99 commits into from
Nov 7, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 6, 2017

Notable Changes

  • CLI:
    • NODE_OPTIONS now supports the --stack-trace-limit option. #16495
  • deps:
    • OpenSSL is upgraded to 1.0.2m #16691
  • http:
    • A 'connect' event handler leak has been fixed. #16725
    • The 103 Early Hints status code is now supported. #16644

Commits

  • [32417999ac] - build: suppress lint-md output (Gibson Fahnestock) #16551
  • [433745e7eb] - build: add missing comma in sources list (Daniel Bevenius) #16613
  • [8bc5249223] - build: make test-doc and lint addon docs (Joyee Cheung) #16377
  • [88ad01fce7] - build: make doc target quiet (Daniel Bevenius) #16516
  • [f3e01618f1] - build,src: Add CloudABI as a POSIX-like runtime environment. (Ed Schouten) #16612
  • [7349d42945] - (SEMVER-MINOR) cli: add --stack-trace-limit to NODE_OPTIONS (Anna Henningsen) #16495
  • [ed0fbd8d72] - deps: cherry-pick e7f4e9e from upstream libuv (Bartosz Sosnowski) #16724
  • [185229e258] - deps: update openssl asm and asm_obsolete files (Shigeki Ohtsu) #16691
  • [162686f5f4] - deps: add -no_rand_screen to openssl s_client (Shigeki Ohtsu) nodejs/io.js#1836
  • [e0f6dee961] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) iojs/io.js#1389
  • [3d7eea5da8] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) iojs/io.js#1389
  • [3438765781] - deps: copy all openssl header files to include dir (Shigeki Ohtsu) #16691
  • [b130febd1d] - deps: upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691
  • [90e8e81bbb] - doc: mention constant-time in crypto doc (Mithun Sasidharan) #16604
  • [dee7800ae8] - doc: add links to EventEmitter in errors.md (Delapouite) #16861
  • [f097e2775b] - doc: fix a link in dgram.md (Vse Mozhet Byt) #16854
  • [978aa8476b] - doc: add isTTY property documentation (SonaySevik) #16828
  • [6739f41f2d] - doc: fix json generator warnings (Luigi Pinca) #16742
  • [2bb148f7bb] - doc: make stream.Readable consistent (Sakthipriyan Vairamani (thefourtheye)) #16786
  • [e05d4f43b6] - doc: correct effects to affects (gowpen) #16794
  • [d7df4dfa1c] - doc: correct EventEmitter reference (gowpen) #16791
  • [77e4ec8c51] - doc: update license to include node-inspect (Myles Borins) #16659
  • [7388144dbc] - doc: add 9.x to version picker and mark 8.x as LTS (Chris Young) #16672
  • [e585c41487] - doc: add docs for Zlib#close() (Luigi Pinca) #16592
  • [d5ea177652] - doc: add nodejs/gyp team for GYP related issues (Gibson Fahnestock) #16638
  • [09181eb976] - doc: add details about rss on process.memoryUsage (Anthony Nandaa) #16566
  • [3fd7eddb44] - doc: add windowsVerbatimArguments docs (Andrew Stucki) #16299
  • [1771bb5039] - doc: fix Changelog link order (Gibson Fahnestock) #16632
  • [6ee28b2823] - doc: util.isDeepStrictEqual returns boolean (Lucas Azzola) #16653
  • [59a4789eee] - doc: howto decode buffers extending from Writable (dicearr) #16403
  • [d733dd9468] - doc: add *-inl.h include rule to C++ style guide (Joyee Cheung) #16548
  • [1cef9ef1de] - doc: make default values and periods consistent (Matej Krajčovič) #16563
  • [77f0359708] - http: use 'connect' event only if socket is connecting (Luigi Pinca) #16725
  • [9c39d79908] - http: use arrow fns for lexical this in Agent (Bryan English) #16475
  • [1b090c9b66] - http, http2: add 103 Early Hints status code (Yosuke Furukawa) #16644
  • [d6d461003f] - http, tls: better support for IPv6 addresses (Mattias Holmlund) #14772
  • [762a11fab3] - http2: improve errors thrown in header validation (Joyee Cheung) #16718
  • [72d0e7e70b] - http2: refactor multiple internals (James M Snell) #16676
  • [e3283c71ce] - http2: allocate on every chunk send (James M Snell) #16669
  • [dfe56847ac] - http2: refactor settings handling (James M Snell) #16668
  • [bf7dc38ae4] - http2: make sessions garbage-collectible (Anna Henningsen) #16461
  • [3f529620cc] - http2: remove unused assignment (Anna Henningsen) #16461
  • [b50c33470e] - http2: track async state for sending (Anna Henningsen) #16461
  • [224ea159ae] - http2: move uv_prepare handle to Http2Session (Anna Henningsen) #16461
  • [6074c8cdbb] - inspector: include node_platform.h header (Alexey Kuzmin) #16677
  • [e0c7b3d13f] - lib: shuffle v8_prof_polyfill.js for unit testing (Ben Noordhuis) #16769
  • [c14030ec7a] - lib: fix version check in tick processor (Ben Noordhuis) #16769
  • [a0b94f4e12] - lib: refactor ES module loader for readability (Anna Henningsen) #16579
  • [083a6e3830] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) iojs/io.js#1389
  • [05f90478fc] - repl: avoid crashing from null and undefined errors (cPhost) #16574
  • [da66610798] - src: fix -Winconsistent-missing-override warning (Ben Noordhuis) #16726
  • [6a2cb124e3] - src: clean up uv_fs_t's in module_wrap.cc (cjihrig) #16722
  • [8a2b4ee7bb] - src: remove unnecessary call to SetHiddenPrototype (Toon Verwaest) #16554
  • [a87f846cc1] - src: add method to compute storage in WriteWrap (Anna Henningsen) #16727
  • [a814786a06] - src: improve module loader readability (Anna Henningsen) #16536
  • [c40b3c6d2a] - src: add 'dynamic' process.release.lts property (Rod Vagg) #16656
  • [f3a65a85d9] - src: pass context to Get() operations for cares_wrap (Evan Lucas) #16641
  • [4f8765d4c8] - src: remove unused includes in string_bytes.h (Daniel Bevenius) #16606
  • [c4736cfcba] - src: fix etw provider include on Windows (Joyee Cheung) #16639
  • [f31b796175] - src: add InternalCallbackScope util constructor (Anna Henningsen) #16461
  • [97fd6df920] - src: do not include x.h if x-inl.h is included (Joyee Cheung) #16548
  • [2294ba49be] - test: tick processor version check regression test (Ben Noordhuis) #16769
  • [b44157378a] - test: use default assertion message (jonask) #16819
  • [a409b874d9] - test: improve message in test-fs-readfile-pipe-large (fjau) #16840
  • [527dddac2f] - test: remove custom message from assertion (Nicolas Morel) #16824
  • [a85d6e9be8] - test: show incorrect value on test failure (Sean Karson) #16818
  • [50d505c188] - test: include file mode in assert message (Sascha Tandel) #16815
  • [5f88543778] - test: refactor tls test to use fixtres.readSync (Brian O'Connell) #16816
  • [d054e94fdc] - test: add detailed message for assertion failure (Attila Gonda) #16812
  • [6831e42988] - test: use fixtures module in test-repl (Maring, Damian Lion) #16809
  • [ef679803a0] - test: update test to use fixtures.readKey (Dara Hayes) #16811
  • [219ac4bde6] - test: fix typos in read-buffer tests (Jimi van der Woning) #16834
  • [e4b3c00e48] - test: replace fixturesDir with usage of fixtures module (Octavian Ionescu) #16810
  • [021ccb4011] - test: use default assertion messages (John Byrne) #16808
  • [2156828f20] - test: clarified assert message for test-require-json.js (Matthias Reis) #16807
  • [ec1b1108af] - test: replace common.fixturesDir with fixtures module (Dumitru Glavan) #16803
  • [700c5e7795] - test: replace common.fixturesDir with fixtures.readSync() (Adri Van Houdt) #16802
  • [bcd818af2a] - test: replace common.fixturesDir usage (Sascha Tandel) #16800
  • [f3e63f254c] - test: update test to use fixtures (Adam Wegrzynek) #16799
  • [0ab3d37be5] - test: refactor exitedAfterDisconnect test (Rich Trott) #16729
  • [26f1a1d9e9] - test: fix test-cli-node-options on Windows (Anna Henningsen) #16709
  • [fc58c5231f] - test: fix malformed parallel.status line (Rich Trott) #16702
  • [689c9d401e] - test: mark test-async-wrap-uncaughtexception as flaky (Refael Ackermann) #16694
  • [0b337cbee8] - test: fix flaky test-http2-server-rst-stream.js (Anatoli Papirovski) #16690
  • [5077faffaa] - test: pause child until parent is ready (jBarz) #15774
  • [d178c6dc91] - test: update process-release for Node 8 Carbon (Jeremiah Senkpiel) #16656
  • [ffe4d7b468] - test: increase coverage for ModuleMap (Rob Paton) #16045
  • [f9b2099d51] - test: use fixtures module in test-https-pfx (Ken Takagi) #15895
  • [6998591be7] - test,net: remove scatological terminology (Rich Trott) #16599
  • [87b4e3ed49] - tls: accept array of protocols in TLSSocket (Mark S. Everitt) #16655
  • [e9396d28b1] - tools: remove unneeded parentheses in doc/html.js (Vse Mozhet Byt) #16845
  • [6e22dc817f] - tools: replace string concatenation with template literals (Kevin Yu) #16804
  • [e781d93bd0] - tools: replace string concatenation with template literals (Giovanni Lela) #16806
  • [422d3158ee] - tools: replace string concetation with templates (Patrick Heneise) #16801
  • [fa5a8419c7] - tools: update to ESLint 4.10.0 (cjihrig) #16738
  • [326a048a5c] - tools: add fixer for no-let-in-for-declaration (Weijia Wang) #16642
  • [d6a0ffe367] - zlib: warn before crash on invalid internals usage (Anna Henningsen) #16657

shigeki and others added 30 commits November 3, 2017 12:24
This replaces all sources of openssl-1.0.2m.tar.gz into
deps/openssl/openssl

PR-URL: nodejs#16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
All symlink files in `deps/openssl/openssl/include/openssl/`
are removed and replaced with real header files to avoid
issues on Windows. Two files of opensslconf.h in crypto and
include dir are replaced to refer config/opensslconf.h.

PR-URL: nodejs#16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reapply b910613 .

Fixes: nodejs#589
PR-URL: nodejs#1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: nodejs#1461
PR-URL: nodejs#1836
Reviewed-By: Ben Noordhuis <[email protected]>
Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc
version was 5.4.0 and nasm version was 2.11.08.

Also asm files in asm_obsolete dir to support old compiler and
assembler are regenerated without CC and ASM envs.

PR-URL: nodejs#16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Original commit message:
    tty, win: get SetWinEventHook pointer at startup

    SetWinEventHook is not available on some Windows versions.

    Fixes: nodejs#16603
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: nodejs#16724
Fixes: nodejs#16603
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: nodejs#16657
Refs: nodejs#16649
Refs: nodejs#14161
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Currently it can be a little difficult to detect errors in the output
from the doc target. This commit suggests reducing the output to make it
easier to identify errors.

PR-URL: nodejs#16516
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
- Implements the make test-doc target that build, verify
  and lint docs
- Lint the C++ snippets in addon docs
- When generating addons and running the JS linter,
  use the global node executable if it is not built.
  Therefore one does not have to build node in order to
  run make test-doc.

PR-URL: nodejs#16377
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#16563
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#16548
Fixes: nodejs#16519
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#16548
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
As far as I understand it, `Nghttp2Session` should not be concerned
about how its consumers handle I/O.

PR-URL: nodejs#16461
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Add an utility constructor for `AsyncWrap` classes that wish to
leverage `InternalCallbackScope`s.

PR-URL: nodejs#16461
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sending pending data may involve running arbitrary JavaScript code.
Therefore, it should involve a callback scope.

PR-URL: nodejs#16461
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
When assigning to a union twice, the first assignment is a no-op.

PR-URL: nodejs#16461
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Use weak handles to track the lifetime of an `Http2Session` instance.

Refs: nodejs/http2#140
PR-URL: nodejs#16461
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: nodejs#16639
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
When `throw undefined` or `throw null` is executed, the REPL crashes.
This change does a check for `null|undefined` before accessing an
error's properties to prevent crashing.

Fixes: nodejs#16545
Fixes: nodejs#16607

PR-URL: nodejs#16574
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Improved stream documentation with an example of how to decode buffers
to strings within a custom Writable.

Fixes: nodejs#15369
PR-URL: nodejs#16403
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
PR-URL: nodejs#16653
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
PR-URL: nodejs#15895
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#16606
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: XadillaX <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h

PR-URL: nodejs#16613
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Add test for ModuleMap set with ModuleJob but bad url.

PR-URL: nodejs#16045
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
CloudABI is a compact POSIX-like runtime that makes use of
capability-based security. More details:
https://github.com/NuxiNL/cloudlibc

* src: Disable use of pwd.h, grp.h and get*uid() on CloudABI.
As CloudABI is intended to run applications in cluster contexts (e.g.,
on Kubernetes), they are oblivious of UNIX credentials. Extend the
existing preprocessor checks to disable any use of these interfaces,
just like on Windows, Android, etc.

* src: Explicitly include <netdb.h>.
cares_wrap.cc calls into functions like getnameinfo() and getaddrinfo().
These functions tend to be available implicitly through <uv.h>, but we'd
better still include this header explicitly.

On CloudABI, we make use of a custom implementation of libuv that does
not implicitly include header files like <netdb.h>.

PR-URL: nodejs#16612
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#16632
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Brian White <[email protected]>
PR-URL: nodejs#16599
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
brianoconnell and others added 14 commits November 7, 2017 08:26
PR-URL: nodejs#16816
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
- Fix `console.countReset()` signature
- Fix `console.group()` arguments list

PR-URL: nodejs#16742
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
If the REPL history file is created with an invalid mode include
the failed mode in the error message.

PR-URL: nodejs#16815
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: nodejs#16818
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
The custom message means that the values involved are not reported.
Remove the custom message for a more detailed error message.

PR-URL: nodejs#16824
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Improve assertion message by including expected and actual values.

PR-URL: nodejs#16840
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#16828
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
In test-child-process-spawnsync, the assert.strictEqual() custom
message was hiding information about why the test has failed. It
just showed what value is expected and in case of failure we want to
know which value has caused test to fail.

PR-URL: nodejs#16819
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Fix a compiler warning that was introduced in commit 4db1bc8
("http2: allocate on every chunk send") by adding an `override` keyword.

PR-URL: nodejs#16726
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Introduced in 70832bc ("build: add V8 embedder version string".)

Fixes: nodejs#16736
PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Make it possible to test the versionCheck() function from that file in
isolation.

PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Verify that v8-version log lines are parsed and matched correctly.

Fixes: nodejs#16736
PR-URL: nodejs#16769
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#16854
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#16861
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@cjihrig cjihrig changed the title WIP: v9.1.0 proposal v9.1.0 proposal Nov 7, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 7, 2017

doc/api/http2.md Outdated
@@ -1471,7 +1471,7 @@ not be emitted.
<!-- YAML
added: v8.4.0
changes:
- version: REPLACEME
- version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

Notable changes:

* CLI:
  - NODE_OPTIONS now supports the --stack-trace-limit option.
    nodejs#16495
* deps:
  - OpenSSL is upgraded to 1.0.2m
    nodejs#16691
* http:
  - A 'connect' event handler leak has been fixed.
    nodejs#16725
  - The 103 Early Hints status code is now supported.
    nodejs#16644

PR-URL: nodejs#16851
@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 7, 2017

@cjihrig
Copy link
Contributor Author

cjihrig commented Nov 7, 2017

Looks like the only CI failure was #16859. Release builds are almost done - just waiting on ARM.

@cjihrig cjihrig merged commit 5f5ef42 into nodejs:v9.x Nov 7, 2017
@cjihrig cjihrig deleted the v9.1.0-proposal branch November 7, 2017 17:52
cjihrig added a commit that referenced this pull request Nov 7, 2017
Notable changes:

* CLI:
  - NODE_OPTIONS now supports the --stack-trace-limit option.
    #16495
* deps:
  - OpenSSL is upgraded to 1.0.2m
    #16691
* http:
  - A 'connect' event handler leak has been fixed.
    #16725
  - The 103 Early Hints status code is now supported.
    #16644

PR-URL: #16851
cjihrig added a commit to nodejs/nodejs.org that referenced this pull request Nov 7, 2017
@MylesBorins MylesBorins self-assigned this Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.