crypto: add sync methods, deprecate optional callbacks #189
Conversation
|
I like this. @iojs/tc |
|
+1 |
|
Someone mentioned on another issue (I can't find right now) that we should consider aligning our crypto API with the WebCryptoAPI, specifically using |
|
@ruimarinho Since 1.0.0-alpha is pushing for release, not right now. Though if there's not an official issue open asking for it then the issue should be created. |
Yes, crypto.pbkdf2 |
| exports.pseudoRandomBytes = util.deprecateSync(pseudoRandomBytes, '`crypto.pseudoRandomBytes(size)` is deprecated. Please use `crypto.pseudoRandomBytesSync(size)` instead.'); | ||
| exports.pseudoRandomBytesSync = pseudoRandomBytes; | ||
|
|
||
| exports.rng = util.deprecateSync(randomBytes, '`crypto.rng(size)` is deprecated. Please us `crypto.rngSync(size)` instead.'); |
There was a problem hiding this comment.
“Please us” → “Please use” for these last two messages.
|
what's the status on this? if desired, i can rebase and reopen for |
|
I'm pretty sure doc updates would be a necessity to merge this in, but I don't believe a rebase and reopen is necessary, as a contributor would merge it manually anyways (unless there are merge conflicts). I could be corrected on that. |
…s#186) (nodejs#189) * Fix test-http-server-keepalive-req-gc * Format --------- Co-authored-by: Etienne Pierre-Doray <[email protected]> Co-authored-by: Etienne Pierre-doray <[email protected]>
See #5
syncversion. after all this is about the public API. is that something you guys want?.randomBytes()and.pseudoRandomBytes(). were there others?