[v6.x] test: remove orphaned entries from status #19042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
inspector
2 tasks
kfarnung
force-pushed
the
v6.x-backport-18092
branch
from
0f1df01 to
064088b
Compare
|
@kfarnung was this meant to be submitted against v6.x? A handful of these tests you've removed still exists on the release line |
kfarnung
force-pushed
the
v6.x-backport-18092
branch
from
064088b to
7a6d835
Compare
|
@MylesBorins I created a relatively simple script for finding these. I spot checked the current state of the PR against both v6.x and v6.x-staging and it looks correct to me. |
|
Kicked off a new CI run: https://ci.nodejs.org/job/node-test-pull-request/13755/ |
|
landed in 12806ac |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
PR-URL: #19042 Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
PR-URL: #19042 Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
PR-URL: #19042 Reviewed-By: Myles Borins <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test