Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove mark flaky for moved test #19069

Closed
wants to merge 1 commit into from
Closed

test: remove mark flaky for moved test #19069

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@BethGriggs
test: remove mark flaky for moved test
96e8166 
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the
test was moved to sequential.

Refs: nodejs#13592
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Mar 1, 2018
@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/13497/

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@BethGriggs @MylesBorins
test: remove mark flaky for moved test
850da0f 
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the
test was moved to sequential.

Refs: #13592
PR-URL: #19069
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 850da0f

MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@BethGriggs @MylesBorins
test: remove mark flaky for moved test
96c8781 
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the
test was moved to sequential.

Refs: #13592
PR-URL: #19069
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@BethGriggs @MylesBorins
test: remove mark flaky for moved test
4d2efa2 
Remove 'flaky' in parallel.status for test-debug-signal-cluster as the
test was moved to sequential.

Refs: #13592
PR-URL: #19069
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Merged
@BethGriggs BethGriggs deleted the remove-flaky-moved-test branch July 9, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@BethGriggs @gibfahn @MylesBorins @jasnell @Trott @benjamingr @cjihrig @richardlau @gireeshpunathil @nodejs-github-bot