Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: add debugging for WebSocket messages #21473

Closed
wants to merge 1 commit into from
Closed

inspector: add debugging for WebSocket messages #21473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,10 +415,10 @@ struct ContextInfo {
};

// Listing the AsyncWrap provider types first enables us to cast directly
// from a provider type to a debug category. Currently no other debug
// categories are available.
// from a provider type to a debug category.
#define DEBUG_CATEGORY_NAMES(V) \
NODE_ASYNC_PROVIDER_TYPES(V)
NODE_ASYNC_PROVIDER_TYPES(V) \
V(INSPECTOR_SERVER)

enum class DebugCategory {
#define V(name) name,
Expand Down
6 changes: 6 additions & 0 deletions src/inspector_io.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ void InspectorIo::SwapBehindLock(MessageQueue<ActionType>* vector1,

void InspectorIo::PostIncomingMessage(InspectorAction action, int session_id,
const std::string& message) {
Debug(parent_env_, DebugCategory::INSPECTOR_SERVER,
">>> %s\n", message.c_str());
if (AppendMessage(&incoming_message_queue_, action, session_id,
Utf8ToStringView(message))) {
Agent* agent = main_thread_req_->second;
Expand Down Expand Up @@ -395,6 +397,10 @@ void InspectorIo::MainThreadReqAsyncCb(uv_async_t* req) {

void InspectorIo::Write(TransportAction action, int session_id,
const StringView& inspector_message) {
std::string message_str =
protocol::StringUtil::StringViewToUtf8(inspector_message);
Debug(parent_env_, DebugCategory::INSPECTOR_SERVER,
"<<< %s\n", message_str.c_str());
AppendMessage(&outgoing_message_queue_, action, session_id,
StringBuffer::create(inspector_message));
int err = uv_async_send(&thread_req_);
Expand Down