-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in fs.md #21579
doc: fix typo in fs.md #21579
Conversation
Fixes simple typo of `excludiing` to `excluding`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
@Trott BTW, should we run an explicit CI-lite in such cases since the CI-lite is launched automatically now as Travis CI? |
CI Lite is only launched for PRs opened by Collaborators. It was not automatically launched on this PR, for example. We could choose to decide that the Travis CI is a sufficient equivalent to Lite CI but I would not want to make that call unilaterally. :-D |
But it did launch on this PR, I've seen this result before your launch: https://github.com/nodejs/node/pull/21579/checks?check_run_id=5686153 Maybe it is launched for doc only PRs whoever makes them? |
See for example #21564: CI-lite is performed in https://github.com/nodejs/node/pull/21564/checks Oops, and that PR is not doc-only... Is this a security breach? |
@vsemozhetbyt Both of those links are to Travis CI runs. Those run automatically on all PRs. That's fine. The Jenkins ci.nodejs.org node-test-pull-request-lite jobs are the ones that only run automatically for PRs opened by Collaborators. |
What is the difference? Since Travis CI seems to contain the same linux-one and linter job. |
Travis CI is sandboxed, so it's OK to run automatically for everyone. However, it makes available only a fraction of the platforms that we test on ourselves and that we care about. So (at this time anyway) it can only replace or duplicate a few functions of our own CI. |
Fixes simple typo of `excludiing` to `excluding`. PR-URL: #21579 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Landed in d6397af |
Fixes simple typo of `excludiing` to `excluding`. PR-URL: #21579 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Fixes simple typo of
excludiing
toexcluding
.make -j4 test
(UNIX) passes