v10.6.0 proposal

.eslintrc.js

@@ -131,7 +131,7 @@ module.exports = {
       {
         object: 'assert',
         property: 'equal',
-        message: 'Use assert.astrictEqual() rather than assert.equal().',
+        message: 'Use assert.strictEqual() rather than assert.equal().',
       },
       {
         object: 'assert',
@@ -243,6 +243,7 @@ module.exports = {
     'node-core/no-unescaped-regexp-dot': 'error',
   },
   globals: {
+    Atomics: false,
     BigInt: false,
     BigInt64Array: false,
     BigUint64Array: false,

.gitignore

@@ -69,6 +69,7 @@ ipch/
 
 /config.mk
 /config.gypi
+/config.status
 /config_fips.gypi
 *-nodegyp*
 /gyp-mac-tool

.mailmap

@@ -2,6 +2,7 @@ Aaron Bieber <[email protected]> <[email protected]>
 Aaron Heckmann <[email protected]> <[email protected]>
 Aayush Ahuja <[email protected]> aayush.a <[email protected]>
 Abe Fettig <[email protected]> <[email protected]>
+Abhimanyu Vashisht <[email protected]>
 Akito Ito <[email protected]> <[email protected]>
 Alejandro Estrada <[email protected]>
 Alejandro Estrada <[email protected]> <[email protected]>
@@ -17,7 +18,9 @@ Alexis Campailla <[email protected]> <[email protected]>
 Alexis Sellier <[email protected]>
 Alexis Sellier <[email protected]> <[email protected]>
 Alfred Cepeda <[email protected]> ALJCepeda <[email protected]>
+Allen Yonghuang Wang <[email protected]>
 Amery <[email protected]> 子丶言 <[email protected]>
+Amit Bendor <[email protected]>
 Andreas Offenhaeuser <[email protected]> anoff <[email protected]>
 Andy Bettisworth <[email protected]>
 Angel Stoyanov <[email protected]> atstojanov <[email protected]>
@@ -69,10 +72,11 @@ Chew Choon Keat <[email protected]>
 Chris Andrews <[email protected]> cpandrews8 <[email protected]>
 Chris Johnson <[email protected]>
 Chris Young <[email protected]> <[email protected]>
-Claudio Rodriguez <[email protected]> <[email protected]>
-Colin Ihrig <[email protected]>
 Christophe Naud-Dulude <[email protected]> Chris911 <[email protected]>
 Christopher Lenz <[email protected]> <[email protected]>
+Claudio Rodriguez <[email protected]> <[email protected]>
+Colin Ihrig <[email protected]>
+Corey Martin <[email protected]>
 Damien Simonin Feugas <[email protected]>
 Dan Kaplun <[email protected]> <[email protected]>
 Dan Williams <[email protected]> Dan.Williams <[email protected]>
@@ -94,13 +98,15 @@ David Mark Clements <[email protected]> davidmarkclements <david.cleme
 David Mark Clements <[email protected]> davidmarkclements <[email protected]>
 David Siegel <[email protected]> <[email protected]>
 DC <[email protected]> [email protected] <[email protected]>
+Deepjyoti Mondal <[email protected]>
 Domenic Denicola <[email protected]>
 Domenic Denicola <[email protected]> <[email protected]>
 Doug Wade <[email protected]> doug.wade <[email protected]>
 Eduard Burtescu <[email protected]>
 Einar Otto Stangvik <[email protected]>
 Elliott Cable <[email protected]>
 Eric Phetteplace <[email protected]>
+Ernesto Salazar <[email protected]>
 Erwin W. Ramadhan <[email protected]> erwinwahyura <[email protected]>
 Eugene Obrezkov <[email protected]> ghaiklor <[email protected]>
 EungJun Yi <[email protected]>
@@ -226,6 +232,7 @@ Marcin Zielinski <[email protected]> marzelin <[email protected]>
 Marti Martz <[email protected]>
 Martial James Jefferson <[email protected]>
 Martijn Schrage <[email protected]> Oblosys <[email protected]>
+Masato Ohba <[email protected]>
 Matheus Marchini <[email protected]> <[email protected]>
 Matheus Marchini <[email protected]> <[email protected]>
 Matt Lang <[email protected]> matt-in-a-hat <[email protected]>
@@ -253,6 +260,7 @@ Miroslav Bajtoš <[email protected]> <[email protected]>
 Mitar Milutinovic <[email protected]>
 Myles Borins <[email protected]> <[email protected]>
 Myles Borins <[email protected]> <[email protected]>
+Nam Nguyen <[email protected]>
 Nebu Pookins<[email protected]>
 Netto Farah <[email protected]> nettofarah <[email protected]>
 Nicholas Kinsey <[email protected]>
@@ -298,6 +306,7 @@ Ryan Mahan <[email protected]>
 Ryan Scheel <[email protected]> Ryan Scheel <[email protected]>
 Ryan Scheel <[email protected]> Ryan Scheel (Havvy) <[email protected]>
 Saad Quadri <[email protected]> saadq <[email protected]>
+Sagir Khan <[email protected]>
 Sakthipriyan Vairamani <[email protected]>
 Sam Mikes <[email protected]>
 Sam P Gallagher-Bishop <[email protected]> <[email protected]>
@@ -316,6 +325,7 @@ Shannen Saez <[email protected]>
 Shaopeng Zhang <[email protected]> szhang351 <[email protected]>
 Shigeki Ohtsu <[email protected]> <[email protected]>
 Shigeki Ohtsu <[email protected]> <[email protected]>
+Shivang Saxena <[email protected]>
 Shiya Luo <[email protected]> shiya <[email protected]>
 Siddharth Mahendraker <[email protected]> <[email protected]>
 Simon Willison <[email protected]>
@@ -343,6 +353,7 @@ Taylor Woll <[email protected]> taylor.woll <[email protected]>
 Thomas Watson Steen <[email protected]> Thomas Watson <[email protected]>
 Timothy O. Peters <[email protected]>
 Timur Shemsedinov <[email protected]> tshemsedinov <[email protected]>
+Ting Shao <[email protected]>
 Toby Farley <[email protected]> tobyfarley <[email protected]>
 Toby Stableford <[email protected]> toboid <[email protected]>
 Todd Kennedy <[email protected]> <[email protected]>
@@ -378,7 +389,8 @@ Vincent Voyer <[email protected]>
 Vladimir de Turckheim <[email protected]>
 vsemozhetbyt <[email protected]> Vse Mozhet Byt <[email protected]>
 Wang Xinyong <[email protected]> <[email protected]>
-Weijia Wang <[email protected]> starkwang <[email protected]>
+Weijia Wang <[email protected]>
+Weijia Wang <[email protected]> starkewang <[email protected]>
 Wei-Wei Wu <[email protected]>
 Willi Eggeling <[email protected]>
 Will Hayslett <[email protected]>
@@ -390,6 +402,7 @@ Yazhong Liu <[email protected]> Yazhong Liu <[email protected]>
 Yazhong Liu <[email protected]> Yorkie <[email protected]>
 Yazhong Liu <[email protected]> Yorkie <[email protected]>
 Yazhong Liu <[email protected]> Yorkie Liu <[email protected]>
+Yingchen Xue <[email protected]>
 Yoshihiro KIKUCHI <[email protected]>
 Yosuke Furukawa <[email protected]> <[email protected]>
 Yuichiro MASUI <[email protected]>

.travis.yml

@@ -18,9 +18,6 @@ matrix:
       script:
         - make -j2 test-ci
 before_install:
-  - export HOMEBREW_NO_AUTO_UPDATE=1 # work around https://github.com/travis-ci/travis-ci/issues/7456
-  - if [ $TRAVIS_OS_NAME = osx ]; then brew install ccache; fi
-  - export PATH="/usr/local/opt/ccache/libexec:$PATH"
   - export CXX="ccache clang++ -Qunused-arguments"
-  - export CC="ccache clang -Qunused-arguments"
+  - export CC="ccache clang -Qunused-arguments -Wno-unknown-warning-option"
   - export JOBS=2

AUTHORS

@@ -2197,5 +2197,44 @@ TSUYUSATO Kitsune <[email protected]>
 daGo <[email protected]>
 Lambdac0re <[email protected]>
 Yulong Wang <[email protected]>
+David Goldstein <[email protected]>
+Francesco Falanga <[email protected]>
+Maya Lekova <[email protected]>
+RakshithNM <[email protected]>
+David Humphrey <[email protected]>
+Ting Shao <[email protected]>
+Alex Fernández <[email protected]>
+Yingchen Xue <[email protected]>
+Dan Kang <[email protected]>
+Masato Ohba <[email protected]>
+я котик пур-пур <[email protected]>
+Corey Martin <[email protected]>
+chainhelen <[email protected]>
+Tim Seckinger <[email protected]>
+Nam Nguyen <[email protected]>
+Nicholas Dangles <[email protected]>
+Amit Bendor <[email protected]>
+Abhimanyu Vashisht <[email protected]>
+Sagir Khan <[email protected]>
+Kael Zhang <[email protected]>
+Unknown <[email protected]>
+Blaine Bublitz <[email protected]>
+Shailesh Shekhawat <[email protected]>
+Davis Okoth <[email protected]>
+Shivang Saxena <[email protected]>
+Lucas Liepert <[email protected]>
+Miklos Suveges <[email protected]>
+Ernesto Salazar <[email protected]>
+Tommaso Allevi <[email protected]>
+Evandro Oliveira <[email protected]>
+Kenny Yuan <[email protected]>
+Hristijan Gjorgjievski <[email protected]>
+Aliaksei Tuzik <[email protected]>
+Misty De Meo <[email protected]>
+James Kylstra <[email protected]>
+Shelley Vohr <[email protected]>
+Deepjyoti Mondal <[email protected]>
+Brett Kiefer <[email protected]>
+Kevin Thomas <[email protected]>
 
 # Generated by tools/update-authors.sh

CHANGELOG.md

@@ -33,7 +33,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V10.md#10.5.0">10.5.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V10.md#10.6.0">10.6.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V10.md#10.5.0">10.5.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V10.md#10.4.1">10.4.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V10.md#10.4.0">10.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V10.md#10.3.0">10.3.0</a><br/>

LICENSE

@@ -93,11 +93,7 @@ The externally maintained libraries used by Node.js are:
 
 - HTTP Parser, located at deps/http_parser, is licensed as follows:
   """
-    http_parser.c is based on src/http/ngx_http_parse.c from NGINX copyright
-    Igor Sysoev.
-
-    Additional changes are licensed under the same terms as NGINX and
-    copyright Joyent, Inc. and other Node contributors. All rights reserved.
+    Copyright Joyent, Inc. and other Node contributors.
 
     Permission is hereby granted, free of charge, to any person obtaining a copy
     of this software and associated documentation files (the "Software"), to
@@ -612,7 +608,7 @@ The externally maintained libraries used by Node.js are:
 
 - OpenSSL, located at deps/openssl, is licensed as follows:
   """
-    Copyright (c) 1998-2017 The OpenSSL Project.  All rights reserved.
+    Copyright (c) 1998-2018 The OpenSSL Project.  All rights reserved.
 
     Redistribution and use in source and binary forms, with or without
     modification, are permitted provided that the following conditions
@@ -715,6 +711,9 @@ The externally maintained libraries used by Node.js are:
       - Valgrind client API header, located at third_party/valgrind/valgrind.h
         This is release under the BSD license.
 
+      - antlr4 parser generator Cpp library located in third_party/antlr4
+        This is release under the BSD license.
+
     These libraries have their own licenses; we recommend you read them,
     as their terms may differ from the terms below.
 

Makefile

@@ -91,14 +91,35 @@ $(NODE_G_EXE): config.gypi out/Makefile
 	$(MAKE) -C out BUILDTYPE=Debug V=$(V)
 	if [ ! -r $@ -o ! -L $@ ]; then ln -fs out/Debug/$(NODE_EXE) $@; fi
 
+CODE_CACHE_DIR ?= out/$(BUILDTYPE)/obj/gen
+CODE_CACHE_FILE ?= $(CODE_CACHE_DIR)/node_code_cache.cc
+
+.PHONY: with-code-cache
+with-code-cache:
+	$(PYTHON) ./configure
+	$(MAKE)
+	mkdir -p $(CODE_CACHE_DIR)
+	out/$(BUILDTYPE)/$(NODE_EXE) --expose-internals tools/generate_code_cache.js $(CODE_CACHE_FILE)
+	$(PYTHON) ./configure --code-cache-path $(CODE_CACHE_FILE)
+	$(MAKE)
+
+.PHONY: test-code-cache
+test-code-cache: with-code-cache
+	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) code-cache
+
 out/Makefile: common.gypi deps/uv/uv.gyp deps/http_parser/http_parser.gyp \
               deps/zlib/zlib.gyp deps/v8/gypfiles/toolchain.gypi \
               deps/v8/gypfiles/features.gypi deps/v8/gypfiles/v8.gyp node.gyp \
               config.gypi
 	$(PYTHON) tools/gyp_node.py -f make
 
 config.gypi: configure
-	$(error Missing or stale $@, please run ./$<)
+	@if [ -x config.status ]; then \
+		./config.status; \
+	else \
+		echo Missing or stale $@, please run ./$<; \
+		exit 1; \
+	fi
 
 .PHONY: install
 install: all ## Installs node into $PREFIX (default=/usr/local).
@@ -175,7 +196,8 @@ coverage-build: all
 		"$(CURDIR)/build/jenkins/scripts/coverage/gcovr-patches-3.4.diff"); fi
 	if [ -d lib_ ]; then $(RM) -r lib; mv lib_ lib; fi
 	mv lib lib_
-	$(NODE) ./node_modules/.bin/nyc instrument --extension .js --extension .mjs lib_/ lib/
+	NODE_DEBUG=nyc $(NODE) ./node_modules/.bin/nyc instrument --extension .js \
+		--extension .mjs --exit-on-error lib_/ lib/
 	$(MAKE)
 
 .PHONY: coverage-test
@@ -274,13 +296,13 @@ test-valgrind: all
 test-check-deopts: all
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --check-deopts parallel sequential
 
-benchmark/misc/function_call/build/Release/binding.node: all \
-		benchmark/misc/function_call/napi_binding.c \
-		benchmark/misc/function_call/binding.cc \
-		benchmark/misc/function_call/binding.gyp
+benchmark/napi/function_call/build/Release/binding.node: all \
+		benchmark/napi/function_call/napi_binding.c \
+		benchmark/napi/function_call/binding.cc \
+		benchmark/napi/function_call/binding.gyp
 	$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
 		--python="$(PYTHON)" \
-		--directory="$(shell pwd)/benchmark/misc/function_call" \
+		--directory="$(shell pwd)/benchmark/napi/function_call" \
 		--nodedir="$(shell pwd)"
 
 # Implicitly depends on $(NODE_EXE).  We don't depend on it explicitly because
@@ -635,12 +657,16 @@ gen-json = tools/doc/generate.js --format=json $< > $@
 gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html \
 			--analytics=$(DOCS_ANALYTICS) $< > $@
 
-out/doc/api/%.json: doc/api/%.md
+out/doc/api/%.json: doc/api/%.md tools/doc/generate.js tools/doc/json.js
 	$(call available-node, $(gen-json))
 
-out/doc/api/%.html: doc/api/%.md
+out/doc/api/%.html: doc/api/%.md tools/doc/generate.js tools/doc/html.js
 	$(call available-node, $(gen-html))
 
+out/doc/api/all.html: $(filter-out out/doc/api/all.html, $(apidocs_html)) \
+	tools/doc/allhtml.js
+	$(call available-node, tools/doc/allhtml.js)
+
 .PHONY: docopen
 docopen: $(apidocs_html)
 	@$(PYTHON) -mwebbrowser file://$(PWD)/out/doc/api/all.html
@@ -1046,11 +1072,17 @@ ifneq ("","$(wildcard tools/remark-cli/node_modules/)")
 
 LINT_MD_DOC_FILES = $(shell ls doc/*.md doc/**/*.md)
 run-lint-doc-md = tools/remark-cli/cli.js -q -f $(LINT_MD_DOC_FILES)
+node_use_openssl = $(shell $(call available-node,"-p" \
+		   "process.versions.openssl != undefined"))
 # Lint all changed markdown files under doc/
 tools/.docmdlintstamp: $(LINT_MD_DOC_FILES)
+ifeq ($(node_use_openssl),true)
 	@echo "Running Markdown linter on docs..."
 	@$(call available-node,$(run-lint-doc-md))
 	@touch $@
+else
+	@echo "Skipping Markdown linter on docs (no crypto)"
+endif
 
 LINT_MD_TARGETS = src lib benchmark tools/doc tools/icu
 LINT_MD_ROOT_DOCS := $(wildcard *.md)
@@ -1059,9 +1091,13 @@ LINT_MD_MISC_FILES := $(shell find $(LINT_MD_TARGETS) -type f \
 run-lint-misc-md = tools/remark-cli/cli.js -q -f $(LINT_MD_MISC_FILES)
 # Lint other changed markdown files maintained by us
 tools/.miscmdlintstamp: $(LINT_MD_MISC_FILES)
+ifeq ($(node_use_openssl),true)
 	@echo "Running Markdown linter on misc docs..."
 	@$(call available-node,$(run-lint-misc-md))
 	@touch $@
+else
+	@echo "Skipping Markdown linter on misc docs (no crypto)"
+endif
 
 tools/.mdlintstamp: tools/.miscmdlintstamp tools/.docmdlintstamp
 
@@ -1115,7 +1151,7 @@ LINT_CPP_EXCLUDE += $(wildcard test/addons-napi/??_*/*.cc test/addons-napi/??_*/
 LINT_CPP_EXCLUDE += src/tracing/trace_event.h src/tracing/trace_event_common.h
 
 LINT_CPP_FILES = $(filter-out $(LINT_CPP_EXCLUDE), $(wildcard \
-	benchmark/misc/function_call/binding.cc \
+	benchmark/napi/function_call/binding.cc \
 	src/*.c \
 	src/*.cc \
 	src/*.h \

README.md

@@ -315,6 +315,8 @@ For more information about the governance of the Node.js project, see
 **Anatoli Papirovski** <[email protected]> (he/him)
 * [aqrln](https://github.com/aqrln) -
 **Alexey Orlenko** <[email protected]> (he/him)
+* [bcoe](https://github.com/bcoe) -
+**Ben Coe** <[email protected]> (he/him)
 * [bengl](https://github.com/bengl) -
 **Bryan English** <[email protected]> (he/him)
 * [benjamingr](https://github.com/benjamingr) -

benchmark/misc/util-extend-vs-object-assign.js

@@ -9,6 +9,10 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, type }) {
+  // Default value for tests.
+  if (type === '')
+    type = 'extend';
+
   let fn;
   if (type === 'extend') {
     fn = util._extend;