gyp: muffle xcode-select warnings

[ryzokuken]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

/cc @nodejs/gyp @gibfahn

sorry for holding this off until today 😅

Do we use a different version of gyp as compared to node-gyp? I found all the right function calls but they were calling different things, so had been wondering.

[nodejs-github-bot]

@ryzokuken build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/259/pipeline

[Trott]

Is the benefit of discarding the spurious error greater than the cost of swallowing other useful debugging information in the event of a real error? (I don't know the answer.)

[gibfahn]

Is the benefit of discarding the spurious error greater than the cost of swallowing other useful debugging information in the event of a real error? (I don't know the answer.)

See discussion in #21520 , but I'd say absolutely. This is the minimal changeset, and it shouldn't swallow any relevant errors.

See nodejs/node-gyp#569 for the pain it causes, I think we should keep the in-tree GYP build as similar as possible to the node-gyp version in any case.

[gibfahn]

LGTM FWIW, but would appreciate other reviews.

[richardlau]

I think we should keep the in-tree GYP build as similar as possible to the node-gyp version in any case.

Radical idea: What if we dropped the in-tree gyp in favour of the one embedded in node-gyp (which we are already dependent on to build the addon tests)?

[gibfahn]

Radical idea: What if we dropped the in-tree gyp in favour of the one embedded in node-gyp (which we are already dependent on to build the addon tests)?

@nodejs/build @nodejs/node-gyp

[jasnell]

What's the status on this one?

[ryzokuken]

@richardlau has an excellent suggestion, but this PR can be landed nonetheless.

[ryzokuken]

Noticed that nobody landed this, but it has enough approvals, etc. Landing this in a few hours unless someone objects.

[refack]

@ryzokuken if you'd like to submit a PR "upstream", where we could debate the finer point of this case.

[refack]

wait... we already landed #21999 16cffb0
😕

superseded by 16cffb0

[richardlau]

Noticed that nobody landed this, but it has enough approvals, etc. Landing this in a few hours unless someone objects.

This has conflicts and needs an up to date CI run.

[refack]

I'm going to close this as superseded. @ryzokuken feel free to reopen.

[ryzokuken]

@refack will do.

[ryzokuken]

Waiiit a minute. Why would I open two PRs with the exact same goal?