tools: remove obsolete entries from license #21979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LICENSE file has a few entries for things that no longer ship with the code base. They are installed via npm instead. Remove them from the license file. Running the license builder on a fresh checkout will result in errors until this change lands, since the necessary information is not in the source tree until the `npm install` happens.
nodejs-github-bot
added
meta
4 tasks
|
@nodejs/build-files |
|
I think the lite CI run is sufficient here since none of this code gets exercised in CI, but if someone thinks a full run is required, go for it. |
addaleax
approved these changes
Jul 25, 2018
maclover7
approved these changes
Jul 26, 2018
richardlau
approved these changes
Jul 26, 2018
| @@ -85,8 +83,6 @@ addlicense "gtest" "deps/gtest" "$(cat ${rootdir}/deps/gtest/LICENSE)" | |||
| addlicense "nghttp2" "deps/nghttp2" "$(cat ${rootdir}/deps/nghttp2/COPYING)" | |||
|
|
|||
| # remark | |||
| addlicense "unified" "deps/unified" "$(cat ${rootdir}/tools/doc/node_modules/unified/LICENSE)" | |||
| addlicense "remark-rehype" "deps/remark-rehype" "$(cat ${rootdir}/tools/doc/node_modules/remark-rehype/LICENSE)" | |||
There was a problem hiding this comment.
Just noting here that these were presumably wrong anyway (i.e. the location should have been tools/doc/node_modules/*.
|
👍 this comment to fast-track. |
hiroppy
approved these changes
Jul 26, 2018
lpinca
approved these changes
Jul 26, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 26, 2018
The LICENSE file has a few entries for things that no longer ship with the code base. They are installed via npm instead. Remove them from the license file. Running the license builder on a fresh checkout will result in errors until this change lands, since the necessary information is not in the source tree until the `npm install` happens. PR-URL: nodejs#21979 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 40a413e |
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
The LICENSE file has a few entries for things that no longer ship with the code base. They are installed via npm instead. Remove them from the license file. Running the license builder on a fresh checkout will result in errors until this change lands, since the necessary information is not in the source tree until the `npm install` happens. PR-URL: #21979 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LICENSE file has a few entries for things that no longer ship with
the code base. They are installed via npm instead. Remove them from the
license file.
Running the license builder on a fresh checkout will
result in errors until this change lands, since the necessary
information is not in the source tree until the
npm installhappens.Checklist