tools: apply linting to first commit in PRs #22452
Conversation
|
Aw yeah...
|
`pad` is now using `toString(10)`, actually we don't need to do this. As for https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toString, `toString(N)` is a radix converter, which isn't proper here for time conversion. PR-URL: #21906 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Ruby <[email protected]>
|
Since this alters |
This comment has been minimized.
This comment has been minimized.
|
Why only the first commit? |
Because subsequent commits are often autosquash commits and I don't want to discourage people from using that. Maybe in the very near future, if we can create a CLI flag for |
|
Is there no way to have CI try to auto squash all of the commits first? |
Oooh, I do like that idea! The |
|
I would like to avoid the first commit if possible. As someone who works a lot with canary and release branches, having Travis run on them is very useful |
OK. I wasn't aware that it was unusually valuable in that context. I'll see if I can figure something out after I sleep and attend the TSC meeting. :-D I'll remove the |
Trott
added
wip
vsemozhetbyt
added
the
meta
This has been enabled only for PR on Once we teach |
|
@refack my comment wasn't about |
.travis.yml
Outdated
| @@ -11,6 +14,8 @@ matrix: | |||
| - NODE=$(which node) make lint-md-build | |||
There was a problem hiding this comment.
Could you add a before_install: stage:
before_install: npm i -g core-validate-commit
instead of the npx call.
I find this more readable (one less magic word in L18)
Ahh the first commit of this PR, not the first commit rule 🤦♂️ |
|
Any progress here? |
Trott
force-pushed
the
travis-updates
branch
from
e8be106 to
f47a05c
Compare
|
Rebased/force-pushed to eliminate conflict. Will get back to this soon, I think... |
Trott
force-pushed
the
travis-updates
branch
3 times, most recently
from
7bf5e39 to
0b7466d
Compare
Use Travis-CI to check the formatting of the first commit in a pull request. This will hopefully reduce formatting errors and nits about them in pull requests.
Use Travis-CI to check the formatting of the first commit in a pull request. This will hopefully reduce formatting errors and nits about them in pull requests. PR-URL: #22452 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Steven R Loomis <[email protected]>
PR-URL: nodejs#23739 Fixes: nodejs#23737 Refs: nodejs#22452 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
PR-URL: #23739 Fixes: #23737 Refs: #22452 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
PR-URL: nodejs#23739 Fixes: nodejs#23737 Refs: nodejs#22452 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
Use Travis-CI to check the formatting of the first commit in a pull request. This will hopefully reduce formatting errors and nits about them in pull requests. PR-URL: #22452 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Steven R Loomis <[email protected]>
Use Travis-CI to check the formatting of the first commit in a pull request. This will hopefully reduce formatting errors and nits about them in pull requests. PR-URL: #22452 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Steven R Loomis <[email protected]>
PR-URL: #23739 Fixes: #23737 Refs: #22452 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
PR-URL: #23739 Fixes: #23737 Refs: #22452 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
PR-URL: #23739 Fixes: #23737 Refs: #22452 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
First commit:
Second commit:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes