doc: clarify fallback behavior of module require #22494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
I am not sure if this is an appropriate team, correct me if I am wrong: cc @nodejs/modules |
|
See new discussion at #22464 re: whether the documented behavior is a bug. |
addaleax
approved these changes
Aug 27, 2018
addaleax
added
the
author ready
|
I think this is ready apart from the fact that it’s not 100 % clear to me that it fully resolves #22464. But if there are no objections in the near future, I’ll go ahead and merge this as-is (i.e. with the |
gdams
approved these changes
Aug 28, 2018
|
Landed in 594dd42, thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Sep 2, 2018
PR-URL: #22494 Fixes: #22464 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: George Adams <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 2, 2018
PR-URL: #22494 Fixes: #22464 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: George Adams <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22494 Fixes: #22464 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: George Adams <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22494 Fixes: #22464 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: George Adams <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #22464
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes