tools: add [src] links to assert.html #22601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`.
nodejs-github-bot
added
doc
addaleax
approved these changes
Aug 30, 2018
test/fixtures/apilinks/reverse.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "asserts.ok": "reverse.js#L10" | |||
There was a problem hiding this comment.
Any chance we could figure out that this should link to L5? (It seems too tricky to me but I figured I’d ask 🙂)
There was a problem hiding this comment.
I'll take a look. I'm inclined to only do that for statements of the form:
x.y = y;
In other words, not for the following (which would be an alias):
x.y = z;
Thoughts?
There was a problem hiding this comment.
I think that sounds reasonable, yeah :)
Hard to explain, see test case for examples. :-)
BridgeAR
approved these changes
Aug 31, 2018
BridgeAR
added
the
author ready
rubys
added a commit
to rubys/node
that referenced
this pull request
Sep 2, 2018
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`. PR-URL: nodejs#22601 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed: 5da1553 |
targos
pushed a commit
that referenced
this pull request
Sep 2, 2018
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`. PR-URL: #22601 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`. PR-URL: #22601 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Parse `const assert = module.exports = ok;` as exporting a constructor named `assert`. PR-URL: #22601 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse
const assert = module.exports = ok;as exporting a constructornamed
assert.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes