Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: specify fast-tracking #22929

Closed
wants to merge 2 commits into from
+6 −3
Closed

doc: specify fast-tracking #22929

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c5247
doc: specify fast-tracking
BridgeAR Sep 18, 2018
d831712
fixup: address comment
BridgeAR Sep 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,12 @@ can be fast-tracked and may be landed after a shorter delay. For example:
* Regressions that happen right before a release, or reported soon after.

When a pull request is deemed suitable to be fast-tracked, label it with
`fast-track`. The pull request can be landed once 2 or more Collaborators
approve both the pull request and the fast-tracking request, and the necessary
CI testing is done.
`fast-track` and add a comment that collaborators may upvote. Please mention the
collaborators that gave an approval before in that comment. If someone disagrees
with the fast-tracking request, please go ahead and remove the label and leave a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove go ahead and

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit part two: probably remove please in this sentence too. Just this?:

If someone disagrees with the fast-tracking request, remove the label and leave a comment...

comment why it should not be fast-tracked. The pull request can be landed once 2
or more Collaborators approve both the pull request and the fast-tracking
request, and the necessary CI testing is done.

### Testing and CI

Expand Down