Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: deprecate UVException() without Isolate* #23175

Closed
wants to merge 1 commit into from
Closed

src: deprecate UVException() without Isolate* #23175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ NODE_DEPRECATED("Use ErrnoException(isolate, ...)",
path);
})

inline v8::Local<v8::Value> UVException(int errorno,
NODE_DEPRECATED("Use UVException(isolate, ...)",
inline v8::Local<v8::Value> UVException(int errorno,
const char* syscall = nullptr,
const char* message = nullptr,
const char* path = nullptr) {
Expand All @@ -148,7 +149,7 @@ inline v8::Local<v8::Value> UVException(int errorno,
syscall,
message,
path);
}
})

/*
* These methods need to be called in a HandleScope.
Expand Down