Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add missing virtual destructors #23215

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/inspector/worker_inspector.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class WorkerDelegate {
const std::string& url,
bool waiting,
std::shared_ptr<MainThreadHandle> worker) = 0;
virtual ~WorkerDelegate() {}
};

class WorkerManagerEventHandle {
Expand Down
1 change: 1 addition & 0 deletions src/node_crypto.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4839,6 +4839,7 @@ class KeyPairGenerationConfig {
virtual bool Configure(const EVPKeyCtxPointer& ctx) {
return true;
}
virtual ~KeyPairGenerationConfig() {}
};

class RSAKeyPairGenerationConfig : public KeyPairGenerationConfig {
Expand Down
1 change: 1 addition & 0 deletions src/node_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ struct HostPort {
class Options {
public:
virtual void CheckOptions(std::vector<std::string>* errors) {}
virtual ~Options() {}
};

// These options are currently essentially per-Environment, but it can be nice
Expand Down