Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: error when empty buffer is passed to filehandle.read() #23250

Closed
wants to merge 3 commits into from
Closed

test: error when empty buffer is passed to filehandle.read() #23250

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea4b362
test: error when empty buffer is passed to filehandle.read()
Sep 30, 2018
464c83a
test: use async function for filehandle.read() test
Oct 4, 2018
41afe00
test: make error message aligned
Oct 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/parallel/test-fs-read-empty-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const assert = require('assert');
const fs = require('fs');
const filepath = fixtures.path('x.txt');
const fd = fs.openSync(filepath, 'r');
const fsPromises = fs.promises;

const buffer = new Uint8Array();

Expand All @@ -26,3 +27,15 @@ assert.throws(
'Received Uint8Array []'
}
);

(async () => {
const filehandle = await fsPromises.open(filepath, 'r');
assert.rejects(
() => filehandle.read(buffer, 0, 1, 0),
{
code: 'ERR_INVALID_ARG_VALUE',
message: 'The argument \'buffer\' is empty and cannot be written. ' +
'Received Uint8Array []'
}
);
})();