Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: add test case for close before connect #24054

Closed
wants to merge 1 commit into from
Closed

http2: add test case for close before connect #24054

wants to merge 1 commit into from

Conversation

antsmartian
Copy link
Contributor

@antsmartian antsmartian commented Nov 3, 2018 •
edited by BridgeAR
Loading

Test wasn't covering few lines http2 code coverage. Added test for the same.

/ cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 3, 2018
@antsmartian antsmartian changed the title http: add test case for goaway scenario http: add test case for goaway Nov 3, 2018
@antsmartian antsmartian force-pushed the test-goaway branch 2 times, most recently from a58bcb1 to 6ee8f4f Compare November 3, 2018 07:56
@antsmartian antsmartian changed the title http: add test case for goaway test: http2 add test case for close before connect Nov 3, 2018
@antsmartian antsmartian changed the title test: http2 add test case for close before connect http2: add test case for close before connect Nov 3, 2018
@antsmartian
Copy link
Contributor Author

Bump @jasnell

@antsmartian
Copy link
Contributor Author

Full CI: https://ci.nodejs.org/job/node-test-pull-request/20018/

@antsmartian
Copy link
Contributor Author

ping @nodejs/http2

@BridgeAR
Copy link
Member

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/20044/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 10, 2019
@antsmartian
Copy link
Contributor Author

antsmartian commented Jan 14, 2019 •
edited
Loading

Landed in 7f91329 🎉

antsmartian added a commit that referenced this pull request Jan 14, 2019
@antsmartian
http2: add test case for goaway
7f91329 
PR-URL: #24054
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@antsmartian antsmartian deleted the test-goaway branch January 14, 2019 02:54
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@antsmartian @addaleax
http2: add test case for goaway
26f2eb8 
PR-URL: #24054
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@antsmartian @BridgeAR
http2: add test case for goaway
a34251d 
PR-URL: nodejs#24054
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@antsmartian @BethGriggs
http2: add test case for goaway
c18366f 
PR-URL: #24054
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@antsmartian @BethGriggs
http2: add test case for goaway
6fde094 
PR-URL: #24054
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@antsmartian @MylesBorins
http2: add test case for goaway
ba6829d 
PR-URL: #24054
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antsmartian @BridgeAR @mcollina @jasnell @nodejs-github-bot