Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.x backport] doc: correct async_hooks resource names #24683

Closed
wants to merge 1 commit into from
Closed

[v10.x backport] doc: correct async_hooks resource names #24683

wants to merge 1 commit into from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Nov 27, 2018

Correct async hooks resource names to match the implementation:
TCPSERVER => TCPSERVERWRAP

Refs: #17157
Refs: #24001

Checklist

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. v10.x labels Nov 27, 2018
@Trott
Copy link
Member

Trott commented Nov 30, 2018

Needs a rebase or something? Seems to have far too many commits.

@Flarna
Copy link
Member Author

Flarna commented Nov 30, 2018

No idea what exactly I did wrong but it should be corrected now.

Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`

Refs: #17157
@Flarna
Copy link
Member Author

Flarna commented Dec 12, 2018

Rebased (twice)

MylesBorins pushed a commit that referenced this pull request Dec 21, 2018
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`

Backport-PR-URL: #24683
PR-URL: #24001
Refs: #21971
Refs: #17157
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 57ccaf6

@Flarna Flarna deleted the v10-async_hooks_doc branch December 21, 2018 17:25
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
Correct async hooks resource names to match the implementation:
`TCPSERVER` => `TCPSERVERWRAP`

Backport-PR-URL: #24683
PR-URL: #24001
Refs: #21971
Refs: #17157
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants