[10.x] deps: V8: cherry-pick 52a9e67

[ofrobots]

Original commit message:

[turbofan] Fix ObjectCreate's side effect annotation.

Bug: chromium:888923
Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79
Reviewed-on: https://chromium-review.googlesource.com/1245763
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Jaroslav Sevcik <[email protected]>
Cr-Commit-Position: refs/heads/master@{#56236}

Refs: v8/v8@52a9e67

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1935/
CI: https://ci.nodejs.org/job/node-test-pull-request/19502/

[nodejs-github-bot]

@ofrobots build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1939/pipeline

[Trott]

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19509/

[Trott]

Is the test-bootstrap-modules failure on CI with --worker relevant? It happened both CI runs...

[ofrobots]

It doesn't repro on my machine. I've launched that worker job again: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3258/.

[Trott]

It doesn't repro on my machine. I've launched that worker job again: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3258/.

To repro locally, you ran it with something like this?:

tools/test.py --worker parallel/test-bootstrap-modules

(The --worker flag to tools/test.py is the important bit, I think.)

[ofrobots]

Yeah. I cannot seem to be able to reproduce this with that command, or with the command to run the whole default suite. It would be good to know if there are other environmental differences on that "freestyle" job.

[Trott]

Here it is happening on a different v10.x PR/CI run. So I think the test is just broken on v10.x-staging.

https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3261/

@nodejs/releasers How to proceed here? Land anyway and a releaser will bisect to figure out where/when CI started failing? 😱

[Trott]

Possibly relevant: #23876

Also: /ping @nodejs/workers

[ofrobots]

AFAICT, the test starting failing at e872089

[Trott]

AFAICT, the test starting failing at e872089

@codebytere ^^^^^^^^^^

[MylesBorins]

looks like this is a new build target. Is it failing anywhere else? cc @nodejs/build

[ofrobots]

Fixing the regression in this pre-req change: #25112

[MylesBorins]

LGTM

[MylesBorins]

landed in 844bd62