Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove obsolete eslint comments #25088

Merged
merged 1 commit into from
Dec 19, 2018
Merged

test: remove obsolete eslint comments #25088

merged 1 commit into from
Dec 19, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 17, 2018

The surrounding code was updated, making these eslint-disable comments obsolete.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1979/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 17, 2018
@cjihrig cjihrig force-pushed the lint branch 2 times, most recently from feb4468 to 8df742d Compare December 19, 2018 16:02
@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 19, 2018

Yellow CI between https://ci.nodejs.org/job/node-test-pull-request/19679/ and https://ci.nodejs.org/job/node-test-pull-request/19680/

@cjihrig
test: remove obsolete eslint comments
35a8906 
The surrounding code was updated, making these eslint-disable
comments obsolete.

PR-URL: nodejs#25088
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig merged commit 35a8906 into nodejs:master Dec 19, 2018
@cjihrig cjihrig deleted the lint branch December 19, 2018 16:06
@joyeecheung joyeecheung mentioned this pull request Dec 19, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Dec 25, 2018
@cjihrig @MylesBorins
test: remove obsolete eslint comments
d09e333 
The surrounding code was updated, making these eslint-disable
comments obsolete.

PR-URL: #25088
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 25, 2018
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig @refack
test: remove obsolete eslint comments
4c88bb1 
The surrounding code was updated, making these eslint-disable
comments obsolete.

PR-URL: nodejs#25088
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@antsmartian antsmartian antsmartian approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @nodejs-github-bot @jasnell @Trott @addaleax @antsmartian @targos @richardlau @BridgeAR @BethGriggs