v10.15.0 proposal #25176
Merged
v10.15.0 proposal #25176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
lib / src
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
51c36d7 to
34a76c1
Compare
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
34a76c1 to
a5e2e86
Compare
MylesBorins
added a commit
that referenced
this pull request
Dec 21, 2018
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
PR-URL: #25176
richardlau
reviewed
Dec 22, 2018
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
a5e2e86 to
daa54f3
Compare
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
daa54f3 to
fce1b91
Compare
This comment has been minimized.
This comment has been minimized.
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
fce1b91 to
4e393f9
Compare
MylesBorins
added a commit
that referenced
this pull request
Dec 22, 2018
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
PR-URL: #25176
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
4e393f9 to
b4496e0
Compare
MylesBorins
added a commit
that referenced
this pull request
Dec 22, 2018
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
PR-URL: #25176
cjihrig
approved these changes
Dec 22, 2018
Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: #23089 PR-URL: #24943 Reviewed-By: Colin Ihrig <[email protected]>
Instead of calling into C++ each time we need to check the value of a command line option, cache the option map in a new `internal/options` module for faster access to the values in JS land. PR-URL: #24091 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #25112 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>
PR-URL: #25039 Fixes: #24958 Reviewed-By: Myles Borins <[email protected]>
This commit adds http_parser_set_max_header_size() to the http-parser for overriding the compile time maximum HTTP header size. Backport-PR-URL: #25168 PR-URL: #24811 Fixes: #24692 Refs: nodejs/http-parser#453 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
This commit adds support for uint64_t option parsing. Backport-PR-URL: #25168 PR-URL: #24811 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
Allow the maximum size of HTTP headers to be overridden from the command line. Backport-PR-URL: #25168 co-authored-by: Matteo Collina <[email protected]> PR-URL: #24811 Fixes: #24692 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
b4496e0 to
cb51fc4
Compare
MylesBorins
added a commit
that referenced
this pull request
Dec 25, 2018
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
PR-URL: #25176
|
CI: https://ci.nodejs.org/job/node-test-pull-request/ Added fix to flaky test. CITGM looks good |
Document that the limit was changed from 80KB to 8KB in 1860352. Fixes: #24693 PR-URL: #24700 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]>
This commit exposes the value of --max-http-header-size as a property of the http module. PR-URL: #24860 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
cb51fc4 to
b2d339c
Compare
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
* http:
- add maxHeaderSize property (cjihrig)
#24860
PR-URL: #25176
MylesBorins
force-pushed
the
v10.15.0-proposal
branch
from
b2d339c to
1ae0511
Compare
|
CI: https://ci.nodejs.org/job/node-test-pull-request/19806/ ✅ (only failure is known flake on AIX, retrying) |
MylesBorins
added a commit
that referenced
this pull request
Dec 26, 2018
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
#24811
* http:
- add maxHeaderSize property (cjihrig)
#24860
PR-URL: #25176
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
The 10.14.0 security release introduced some unexpected breakages on
the 10.x release line. This is a special release to fix a regression
in the HTTP binary upgrade response body and add a missing CLI flag
to adjust the max header size of the http parser.
Notable Changes:
* cli:
- add --max-http-header-size flag (cjihrig)
nodejs#24811
* http:
- add maxHeaderSize property (cjihrig)
nodejs#24860
PR-URL: nodejs#25176
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-12-26, Version 10.15.0 'Dubnium' (LTS), @MylesBorins
The 10.14.0 security release introduced some unexpected breakages on the 10.x release line.
This is a special release to fix a regression in the HTTP binary upgrade response body and add
a missing CLI flag to adjust the max header size of the http parser.
Notable Changes
Commits
9b2ffc81c0] - (SEMVER-MINOR) cli: add --max-http-header-size flag (cjihrig) #248116183c7107d] - (SEMVER-MINOR) deps: cherry-pick http_parser_set_max_header_size (cjihrig) #24811e669733595] - doc: describe current HTTP header size limit (Sam Roberts) #24700b6d3afb257] - (SEMVER-MINOR) http: add maxHeaderSize property (cjihrig) #248601aea1e3634] - http: fix regression of binary upgrade response body (Matteo Collina) #25039a57aed144a] - (SEMVER-MINOR) src: add kUInteger parsing (Matteo Collina) #24811527407c49f] - src: cache the result of GetOptions() in JS land (Joyee Cheung) #24091728bc631e5] - test: fix expectation in test-bootstrap-modules (Ali Ijaz Sheikh) #251123e14212f0e] - test: remove magic numbers in test-gc-http-client-onerror (Rich Trott) #24943