test: fix test-tls-securepair-client #25222

Trott · 2018-12-26T06:25:40Z

test-tls-securepair-client has been failing for over a year but no one
noticed because pummel tests are almost never run.

In preparation for running pummel tests once a day in CI, fix
test-tls-securepair-client.

test-tls-securepair-client does not seem to need to be in the pummel
directory. Move it to sequential. (It can't go into parallel because it
uses common.PORT and therefore might conflict with another test that is
using system-assigned available ports.)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2018-12-26T06:25:42Z

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2065/pipeline

Make the deprecated `tls.createSecurePair()` method use other public APIs only (`TLSSocket` in particular). Since `tls.createSecurePair()` has been runtime-deprecated only since Node 8, it probably isn’t quite time to remove it yet, but this patch removes almost all of the code complexity that is retained by it. The API, as it is documented, is retained. However, it is very likely that some users have come to rely on parts of undocumented API of the `SecurePair` class, especially since some of the existing tests checked for those. Therefore, this should definitely be considered a breaking change. PR-URL: #17882 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>

Trott · 2018-12-26T15:58:18Z

Works everywhere now but Windows...

test/sequential/test-tls-securepair-client.js

Trott · 2019-01-05T00:08:05Z

Here's what the Windows failure looks like:

16:02:14 not ok 619 sequential/test-tls-securepair-client
16:02:14   ---
16:02:14   duration_ms: 5.680
16:02:14   severity: fail
16:02:14   exitcode: 1
16:02:14   stack: |-
16:02:14     Using default temp DH parameters
16:02:14     WAIT-ACCEPT
16:02:14     ACCEPT
16:02:14     WAIT-ACCEPT
16:02:14     client connected
16:02:14     (node:5684) [DEP0064] DeprecationWarning: tls.createSecurePair() is deprecated. Please use tls.TLSSocket instead.
16:02:14     assert.js:86
16:02:14       throw new AssertionError(obj);
16:02:14       ^
16:02:14     
16:02:14     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
16:02:14     
16:02:14     -1 !== 0
16:02:14     
16:02:14         at process.<anonymous> (c:\workspace\node-test-binary-windows\test\sequential\test-tls-securepair-client.js:174:12)
16:02:14         at process.emit (events.js:193:15)
16:02:14         at process.exit (internal/process/per_thread.js:150:15)
16:02:14         at Timeout._onTimeout (c:\workspace\node-test-binary-windows\test\sequential\test-tls-securepair-client.js:104:13)
16:02:14         at listOnTimeout (timers.js:324:15)
16:02:14         at processTimers (timers.js:268:5)
16:02:14   ...

test-tls-securepair-client has been failing for over a year but no one noticed because pummel tests are almost never run. In preparation for running pummel tests once a day in CI, fix test-tls-securepair-client.

test-tls-securepair-client does not seem to need to be in the pummel directory. Move it to sequential. (It can't go into parallel because it uses common.PORT and therefore might conflict with another test that is using system-assigned available ports.)

Trott · 2019-01-07T03:27:51Z

Added a common.skip() for Windows. My reasoning is that this test is currently broken and not run in CI at all. This PR fixes it everywhere but Windows and moves it somewhere that it will run in CI. So even if it is skipped on Windows, that's still a significant improvement over the current state. When this lands, I'll open an issue for the test to be fixed on Windows and add a help wanted label to it.

CI: https://ci.nodejs.org/job/node-test-pull-request/19959/

Trott · 2019-01-07T19:37:07Z

Landed in ec5884a...0066fdb

test-tls-securepair-client has been failing for over a year but no one noticed because pummel tests are almost never run. In preparation for running pummel tests once a day in CI, fix test-tls-securepair-client. PR-URL: nodejs#25222 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>

test-tls-securepair-client does not seem to need to be in the pummel directory. Move it to sequential. (It can't go into parallel because it uses common.PORT and therefore might conflict with another test that is using system-assigned available ports.) PR-URL: nodejs#25222 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>

test-tls-securepair-client has been failing for over a year but no one noticed because pummel tests are almost never run. In preparation for running pummel tests once a day in CI, fix test-tls-securepair-client. PR-URL: #25222 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>

test-tls-securepair-client does not seem to need to be in the pummel directory. Move it to sequential. (It can't go into parallel because it uses common.PORT and therefore might conflict with another test that is using system-assigned available ports.) PR-URL: #25222 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>