Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH #25296

Closed
wants to merge 2 commits into from
Closed

test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH #25296

wants to merge 2 commits into from

Conversation

fshaikh
Copy link
Contributor

@fshaikh fshaikh commented Dec 31, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] tests and/or benchmarks are included
  • [x ] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 31, 2018
antsmartian
antsmartian approved these changes Jan 1, 2019
View reviewed changes
Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..

(I guess we had the same test case written over this PR: #24014 and it wasn't merged but got closed)

@antsmartian
Copy link
Contributor

Hello @fshaikh and thanks for your first pull request. I see linter issue, could you please fix the below:

/home/travis/build/nodejs/node/test/parallel/test-http2-origin.js
  73:59  error  Missing semicolon  semi

@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2019
@antsmartian
Copy link
Contributor

CI Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2123/

@addaleax
Copy link
Member

addaleax commented Jan 2, 2019

Full CI: https://ci.nodejs.org/job/node-test-pull-request/19913/

@danbev
Copy link
Contributor

danbev commented Jan 7, 2019

Landed in 076d8b9. 🎉

@danbev danbev closed this Jan 7, 2019
danbev pushed a commit that referenced this pull request Jan 7, 2019
@fshaikh @danbev
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
076d8b9 
PR-URL: #25296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 9, 2019
@fshaikh @addaleax
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
239d5ec 
PR-URL: #25296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@fshaikh @refack
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
f817f57 
PR-URL: nodejs#25296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@fshaikh @BridgeAR
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
890c7b6 
PR-URL: nodejs#25296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@fshaikh @BethGriggs
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
2936958 
PR-URL: #25296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@fshaikh @BethGriggs
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
f8d6e3f 
PR-URL: #25296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@fshaikh @MylesBorins
test: http2 origin length ERR_HTTP2_ORIGIN_LENGTH
374a07d 
PR-URL: #25296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@trivikr trivikr mentioned this pull request Oct 24, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@antsmartian antsmartian antsmartian approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@fshaikh @antsmartian @addaleax @danbev @jasnell @lpinca @cjihrig @nodejs-github-bot