Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace Google servers with localhost #25694

Closed
wants to merge 1 commit into from
Closed

test: replace Google servers with localhost #25694

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 25, 2019

Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
test: replace Google servers with localhost
472dfc1 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: nodejs#25664
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2381/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 25, 2019
@Trott Trott requested review from XadillaX and joyeecheung January 25, 2019 05:55
@Trott Trott mentioned this pull request Jan 25, 2019
Closed
@Trott
Copy link
Member Author

Trott commented Jan 25, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20316/

mhdawson
mhdawson approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XadillaX
XadillaX approved these changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Jan 26, 2019

Now that the pesky test-performance issue has been resolved, let's re-run CI:

https://ci.nodejs.org/job/node-test-pull-request/20338/

@Trott
Copy link
Member Author

Trott commented Jan 26, 2019 •
edited
Loading

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20339/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 26, 2019
@Trott
Copy link
Member Author

Trott commented Jan 27, 2019

Landed in 6d937c0

@Trott Trott closed this Jan 27, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 27, 2019
@Trott
test: replace Google servers with localhost
6d937c0 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: nodejs#25664

PR-URL: nodejs#25694
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@Trott @addaleax
test: replace Google servers with localhost
190c063 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664

PR-URL: #25694
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jan 29, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@Trott @BethGriggs
test: replace Google servers with localhost
3fab8be 
Replace Google DNS servers with 127.0.0.1 in
test-dns-setserver-when-querying.

Refs: #25664

PR-URL: #25694
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the de-internet-ize branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @lpinca @targos @cjihrig @XadillaX @mhdawson