Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused field in node_http2.h #25727

Closed
wants to merge 1 commit into from
Closed

src: remove unused field in node_http2.h #25727

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

The field is no longer needed after this refactor: 0625627.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Jan 26, 2019
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20391/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 28, 2019
@danbev
Copy link
Contributor

danbev commented Jan 29, 2019

Landed in d4d76b6.

@danbev danbev closed this Jan 29, 2019
danbev pushed a commit that referenced this pull request Jan 29, 2019
@gengjiawen @danbev
src: remove unused field in node_http2.h
d4d76b6 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25727
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 29, 2019
@gengjiawen @targos
src: remove unused field in node_http2.h
ebcdbeb 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25727
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jan 29, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@gengjiawen @BethGriggs
src: remove unused field in node_http2.h
0c3dbc7 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25727
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@gengjiawen @BethGriggs
src: remove unused field in node_http2.h
341abab 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25727
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@gengjiawen @MylesBorins
src: remove unused field in node_http2.h
51ec21c 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25727
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @addaleax @danbev @jasnell @cjihrig @nodejs-github-bot