Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid name clash with upper scope in node_trace_buffer.cc #25920

Closed
wants to merge 1 commit into from
Closed

src: avoid name clash with upper scope in node_trace_buffer.cc #25920

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 4, 2019 •
edited
Loading

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 4, 2019
@addaleax
Copy link
Member

addaleax commented Feb 4, 2019

This conflicts with #25896.

I also find it confusing: These are the same objects, so referring to them by the same name makes sense, right?

@gengjiawen
Copy link
Member Author

They are in the same function, so better with different name IMHO.

@gengjiawen gengjiawen force-pushed the feature/redability_node_trace_buffer branch from aff0acc to f25d583 Compare February 5, 2019 02:16
@gengjiawen gengjiawen force-pushed the feature/redability_node_trace_buffer branch from f25d583 to 6c18ed9 Compare February 5, 2019 02:19
@gengjiawen
Copy link
Member Author

Current there is three buffer in this method, give those different name will make it more readable
image

@gengjiawen
Copy link
Member Author

@addaleax give this another thought or leave it the old way ?

@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

@gengjiawen Yeah, I’m still -1 on doing this. You can wait for others to chime in, if you want.

@gengjiawen gengjiawen closed this Feb 6, 2019
@gengjiawen gengjiawen deleted the feature/redability_node_trace_buffer branch February 6, 2019 14:01
@addaleax addaleax mentioned this pull request Feb 25, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gengjiawen @addaleax @nodejs-github-bot