Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert: make a small internal assert module for built-in use #25956

Closed
wants to merge 3 commits into from
Closed

assert: make a small internal assert module for built-in use #25956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e966998
assert: refactor internal assert.js
Trott Feb 6, 2019
0e9b3e7
assert: create internal/assert micro-module
Trott Feb 6, 2019
0a28cdb
lib: replace 'assert' with 'internal/assert' for many built-ins
Trott Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/_http_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

const net = require('net');
const url = require('url');
const assert = require('assert').ok;
const assert = require('internal/assert');
const {
_checkIsHttpToken: checkIsHttpToken,
debug,
Expand Down
2 changes: 1 addition & 1 deletion lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

'use strict';

const assert = require('assert').ok;
const assert = require('internal/assert');
const Stream = require('stream');
const util = require('util');
const internalUtil = require('internal/util');
Expand Down
2 changes: 1 addition & 1 deletion lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

const util = require('util');
const net = require('net');
const assert = require('assert').ok;
const assert = require('internal/assert');
const {
parsers,
freeParser,
Expand Down
2 changes: 1 addition & 1 deletion lib/_tls_wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

require('internal/util').assertCrypto();

const assert = require('assert');
const assert = require('internal/assert');
const crypto = require('crypto');
const net = require('net');
const tls = require('tls');
Expand Down
2 changes: 1 addition & 1 deletion lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const { codes: {
ERR_INVALID_ARG_VALUE,
ERR_INVALID_RETURN_VALUE
} } = require('internal/errors');
const { AssertionError } = require('internal/assert');
const AssertionError = require('internal/assert/assertion_error');
const { openSync, closeSync, readSync } = require('fs');
const { inspect, types: { isPromise, isRegExp } } = require('util');
const { EOL } = require('internal/constants');
Expand Down
Loading