test: increase coverage for assertion_error.js #26065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
changed the title
|
Edited the commit message and force-pushed. CI: https://ci.nodejs.org/job/node-test-pull-request/20757/ ✅ |
cjihrig
approved these changes
Feb 13, 2019
Add a test for long strings and assert.notDeepEqual() to cover code that truncates output when it is longer than 1024 characters.
Trott
added
the
author ready
thefourtheye
approved these changes
Feb 13, 2019
|
Landed in 8e68dc5 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 15, 2019
Add a test for long strings and assert.notDeepEqual() to cover code that truncates output when it is longer than 1024 characters. PR-URL: nodejs#26065 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2019
Add a test for long strings and assert.notDeepEqual() to cover code that truncates output when it is longer than 1024 characters. PR-URL: #26065 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Add a test for long strings and assert.notDeepEqual() to cover code that truncates output when it is longer than 1024 characters. PR-URL: #26065 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for long strings and assert.notDeepEqual() to cover code that
truncates output when it is longer than 1024 characters.
This introduces coverage for https://coverage.nodejs.org/coverage-0a4c69a5c5e8ba93/lib/internal/assert/assertion_error.js.html#L370.
I standardized nearby arrow functions to use braces when they are not intended to return a value.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes