-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: silence compiler warning in openssl-binding #26067
Conversation
Currently, this test generated the following compiler warning: ../binding.cc:33:30: warning: 'TLSv1_2_server_method' is deprecated [-Wdeprecated-declarations] const SSL_METHOD* method = TLSv1_2_server_method(); ^ /node/deps/openssl/openssl/include/openssl/ssl.h:1877:1: note: 'TLSv1_2_server_method' has been explicitly marked deprecated here DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_2_server_method(void)) ^ 1 warning generated. This commit adds -Wno-deprecated-declarations to silence this warning for this test.
Isn't it better to get these warnings, so that we can eventually fix them or at least be aware of them? |
In this particular case the test is deliberately using a deprecated method. It was recently added in #25991 as a regression test since we export OpenSSL symbols to addon authors (who will still get the warnings unless they suppress them like we're doing here for this test). |
Landed in 611043c |
Currently, this test generated the following compiler warning: ../binding.cc:33:30: warning: 'TLSv1_2_server_method' is deprecated [-Wdeprecated-declarations] const SSL_METHOD* method = TLSv1_2_server_method(); ^ /node/deps/openssl/openssl/include/openssl/ssl.h:1877:1: note: 'TLSv1_2_server_method' has been explicitly marked deprecated here DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_2_server_method(void)) ^ 1 warning generated. This commit adds -Wno-deprecated-declarations to silence this warning for this test. PR-URL: #26067 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Currently, this test generated the following compiler warning: ../binding.cc:33:30: warning: 'TLSv1_2_server_method' is deprecated [-Wdeprecated-declarations] const SSL_METHOD* method = TLSv1_2_server_method(); ^ /node/deps/openssl/openssl/include/openssl/ssl.h:1877:1: note: 'TLSv1_2_server_method' has been explicitly marked deprecated here DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_2_server_method(void)) ^ 1 warning generated. This commit adds -Wno-deprecated-declarations to silence this warning for this test. PR-URL: #26067 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Currently, this test generated the following compiler warning: ../binding.cc:33:30: warning: 'TLSv1_2_server_method' is deprecated [-Wdeprecated-declarations] const SSL_METHOD* method = TLSv1_2_server_method(); ^ /node/deps/openssl/openssl/include/openssl/ssl.h:1877:1: note: 'TLSv1_2_server_method' has been explicitly marked deprecated here DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_2_server_method(void)) ^ 1 warning generated. This commit adds -Wno-deprecated-declarations to silence this warning for this test. PR-URL: #26067 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Currently, this test generated the following compiler warning:
This commit adds
-Wno-deprecated-declarations
to silence this warningfor this test.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes