test: remove duplicated buffer negative allocation test

[ZYSzys]

The buffer negative allocation test test-buffer-negative-length.js is almost duplicated with test-buffer-no-negative-allocation.js.

node/test/parallel/test-buffer-negative-length.js

Lines 1 to 17 in 3fbf55a

	'use strict';
	const common = require('../common');
	const assert = require('assert');
	const SlowBuffer = require('buffer').SlowBuffer;
	const bufferNegativeMsg = common.expectsError({
	code: 'ERR_INVALID_OPT_VALUE',
	type: RangeError,
	message: /^The value "[^"]*" is invalid for option "size"$/
	}, 5);
	assert.throws(() => Buffer(-1).toString('utf8'), bufferNegativeMsg);
	assert.throws(() => SlowBuffer(-1).toString('utf8'), bufferNegativeMsg);
	assert.throws(() => Buffer.alloc(-1).toString('utf8'), bufferNegativeMsg);
	assert.throws(() => Buffer.allocUnsafe(-1).toString('utf8'), bufferNegativeMsg);
	assert.throws(() => Buffer.allocUnsafeSlow(-1).toString('utf8'),
	bufferNegativeMsg);

node/test/parallel/test-buffer-no-negative-allocation.js

Lines 1 to 28 in 3fbf55a

	'use strict';
	const common = require('../common');
	const assert = require('assert');
	const msg = common.expectsError({
	code: 'ERR_INVALID_OPT_VALUE',
	type: RangeError,
	message: /^The value "[^"]*" is invalid for option "size"$/
	}, 12);
	// Test that negative Buffer length inputs throw errors.
	assert.throws(() => Buffer(-Buffer.poolSize), msg);
	assert.throws(() => Buffer(-100), msg);
	assert.throws(() => Buffer(-1), msg);
	assert.throws(() => Buffer.alloc(-Buffer.poolSize), msg);
	assert.throws(() => Buffer.alloc(-100), msg);
	assert.throws(() => Buffer.alloc(-1), msg);
	assert.throws(() => Buffer.allocUnsafe(-Buffer.poolSize), msg);
	assert.throws(() => Buffer.allocUnsafe(-100), msg);
	assert.throws(() => Buffer.allocUnsafe(-1), msg);
	assert.throws(() => Buffer.allocUnsafeSlow(-Buffer.poolSize), msg);
	assert.throws(() => Buffer.allocUnsafeSlow(-100), msg);
	assert.throws(() => Buffer.allocUnsafeSlow(-1), msg);

So remove test-buffer-negative-length.js and add SlowBuffer allocation test into test-buffer-no-negative-allocation.js.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/20832/ ✅

[danbev]

@ZYSzys Sorry about this, but would you be able to rebase this and fix the conflict and we can then re-run CI and get it merged. Thanks

[ZYSzys]

@danbev Done, thanks!

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/20958/

[addaleax]

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21090/

[addaleax]

Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25083/

[BridgeAR]

Landed in 6f6f6d4 🎉