doc: fix up N-API support matrix #26377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support matrix was out of date. Update with current status. Fixes: nodejs#25801
nodejs-github-bot
added
doc
cjihrig
approved these changes
Mar 1, 2019
doc/api/n-api.md
Outdated
| | v10.x | | | v10.0.0 | | ||
| | | 1 | 2 | 3 | 4 | | ||
| |:-----:|:-------:|:--------:|:--------:|:--------:| | ||
| | v4.x | | | | | |
There was a problem hiding this comment.
Should EoL versions be removed?
lpinca
approved these changes
Mar 1, 2019
jasnell
approved these changes
Mar 2, 2019
BridgeAR
approved these changes
Mar 3, 2019
|
Lite CI as it is doc only: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2759/ |
|
CI was good, landing |
|
|
mhdawson
added a commit
that referenced
this pull request
Mar 4, 2019
The support matrix was out of date. Update with current status. Fixes: #25801 PR-URL: #26377 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
The support matrix was out of date. Update with current status. Fixes: nodejs#25801 PR-URL: nodejs#26377 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
cjbj
reviewed
Mar 13, 2019
| | | 1 | 2 | 3 | 4 | | ||
| |:-----:|:-------:|:--------:|:--------:|:--------:| | ||
| | v6.x | | | v6.14.2* | | | ||
| | v8.x | v8.0.0* | v8.10.0* | v8.11.2 | | |
There was a problem hiding this comment.
@mhdawson it would be good to have the non-experimental versions listed. E.g. https://github.com/nodejs/abi-stable-node says that "Node.js versions 8.12.0 and above provide N-API as a stable feature"
BethGriggs
pushed a commit
that referenced
this pull request
Apr 16, 2019
The support matrix was out of date. Update with current status. Fixes: #25801 PR-URL: #26377 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
This was referenced May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support matrix was out of date. Update
with current status.
Fixes: #25801
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes