Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: bump test-bootstrap-modules.js limit #26520

Merged
merged 1 commit into from
Mar 8, 2019
Merged

test: bump test-bootstrap-modules.js limit #26520

merged 1 commit into from
Mar 8, 2019

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 8, 2019 •
edited by refack
Loading

Refs: #25594
Fixes: #26528

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2815/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 8, 2019
@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 8, 2019
@joyeecheung
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/21334/
Please thumbs up this reply if you are +1 to fast-track - this unbreaks master.

devsnek
devsnek approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about this

@richardlau richardlau mentioned this pull request Mar 8, 2019
Merged
@joyeecheung joyeecheung mentioned this pull request Mar 8, 2019
Closed
2 tasks
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@richardlau richardlau mentioned this pull request Mar 8, 2019
Closed
@tniessen
Copy link
Member

tniessen commented Mar 8, 2019

Fixes: #26528

@joyeecheung @refack
test: bump test-bootstrap-modules.js limit
4fe66a3 
PR-URL: nodejs#26520
Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@refack refack merged commit 4fe66a3 into nodejs:master Mar 8, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
@joyeecheung @BridgeAR
test: bump test-bootstrap-modules.js limit
4a913a2 
PR-URL: nodejs#26520
Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@joyeecheung @BridgeAR
test: bump test-bootstrap-modules.js limit
78c4dbd 
PR-URL: #26520
Fixes: #26528
Refs: #25594
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joyeecheung @nodejs-github-bot @tniessen @refack @lpinca @cjihrig @richardlau @devsnek @BridgeAR