benchmark: remove deprecated argument #27091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
BridgeAR
approved these changes
Apr 4, 2019
richardlau
approved these changes
Apr 4, 2019
BridgeAR
added
the
author ready
|
The benchmark files are not tested with the CI (@nodejs/build could we add such a job? That way we could just start that in case benchmark files are changed), so I marked this as |
cjihrig
approved these changes
Apr 4, 2019
It's mildly roundabout, but they are run in node-daily-master. So to run them in a PR, you could:
I've done all that. https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5971/ |
Interestingly, it looks like some other recently-landed commit broke the benchmark tests. 😀 |
lpinca
approved these changes
Apr 5, 2019
mihalskiy
approved these changes
Apr 5, 2019
The benchmarks for dns.lookup() include calling it with an empty hostname which results in a deprecation warning. This benchmark seems to be subject to some odd side effects (see Ref below) and we probably generally don't want to benchmark deprecated things by default anyway. Remove the deprecated value from the default list. Bonus is that this will speed up the benchmark. Refs: nodejs#27081 (comment)
|
Landed in 77dee25 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 7, 2019
The benchmarks for dns.lookup() include calling it with an empty hostname which results in a deprecation warning. This benchmark seems to be subject to some odd side effects (see Ref below) and we probably generally don't want to benchmark deprecated things by default anyway. Remove the deprecated value from the default list. Bonus is that this will speed up the benchmark. Refs: nodejs#27081 (comment) PR-URL: nodejs#27091 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks for dns.lookup() include calling it with an empty
hostname which results in a deprecation warning. This benchmark seems to
be subject to some odd side effects (see Ref below) and we probably
generally don't want to benchmark deprecated things by default anyway.
Remove the deprecated value from the default list. Bonus is that this
will speed up the benchmark.
Refs: #27081 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes