Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add Travis job to check for dead URL links #27267

Closed
wants to merge 4 commits into from
Closed

build: add Travis job to check for dead URL links #27267

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bdc627
build: add Travis job to check for dead URL links
richardlau Apr 16, 2019
2c15115
fixup! build: add Travis job to check for dead URL links
richardlau Apr 18, 2019
f6dbf75
fixup! build: add Travis job to check for dead URL links
richardlau Apr 18, 2019
3ed6684
fixup! build: add Travis job to check for dead URL links
richardlau Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,22 @@ jobs:
script:
- NODE=$(which node) make lint lint-py

- name: "Docs"
if: type = pull_request
language: node_js
node_js: "node"
install:
- pyenv global 2.7.15
- make doc-only
- npm install -g linkinator
script:
- if [ "${TRAVIS_PULL_REQUEST}" != "false" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant because of

node/.travis.yml

Line 81 in 3ed6684

if: type = pull_request

DOC_FILES=`curl -sL https://github.com/nodejs/node/pull/${TRAVIS_PULL_REQUEST}.patch | grep -o '\bdoc/api/.*\.md\b'`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DOC_FILES=`curl -sL https://github.com/nodejs/node/pull/${TRAVIS_PULL_REQUEST}.patch | grep -o '\bdoc/api/.*\.md\b'`;
DOC_FILES=`git diff --name-only HEAD...$TRAVIS_BRANCH | grep -o '\bdoc/api/.*\.md\b'`;

Refs: https://stackoverflow.com/questions/41145041/list-files-modified-in-a-pull-request-within-travis

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had trouble with commit message linting before with $TRAVIS_BRANCH which is why we ended up downloading the patch files but I forget the details.

if [ -n "${DOC_FILES}" ]; then
linkinator out/doc/api -r;
fi;
fi

- name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>"
if: type = pull_request
language: node_js
Expand Down