-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v10.x] doc,n-api: update matrix for N-API version 4 #27832
Conversation
The N-API version was bumped to 4 for Node.js 10 in nodejs#25633 Refs: nodejs#25633
Once this lands in a Node.js 10.x release (i.e. the actual version of Node.js 10 that first supports N-API version 4 is known) a follow up PR needs to add that information to the N-API docs on |
@richardlau I assume the REPLACEME's are handled as part of the release process right? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed on |
The N-API version was bumped to 4 for Node.js 10 in #25633 Refs: #25633 PR-URL: #27832 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
The N-API version was bumped to 4 for Node.js 10 in
#25633
Refs: #25633
This should land in the release with the above referenced PR.
cc @nodejs/lts @nodejs/n-api
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes