Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] test: clean up build files #28297

Closed
wants to merge 1 commit into from
Closed

[v10.x] test: clean up build files #28297

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Jun 19, 2019 •
edited
Loading

Files generated by the build process were accidentally included as part
of an earlier commit. This removes them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: clean up build files
b668297 
Files generated by the build process were accidentally included as part
of an earlier commit. This removes them.
@gabrielschulhof gabrielschulhof added test Issues and PRs related to the tests. land-on-v10.x labels Jun 19, 2019
@gabrielschulhof gabrielschulhof added node-api Issues and PRs related to the Node-API. and removed land-on-v10.x labels Jun 19, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24141/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24145/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24147/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24414/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24499/

BethGriggs pushed a commit that referenced this pull request Jul 16, 2019
@BethGriggs
test: clean up build files
c940dc0 
Files generated by the build process were accidentally included as part
of an earlier commit. This removes them.

PR-URL: #28297
Reviewed-By: Beth Griggs <[email protected]>
@BethGriggs
Copy link
Member

Landed on v10.x-staging

@BethGriggs BethGriggs closed this Jul 16, 2019
BethGriggs pushed a commit that referenced this pull request Jul 17, 2019
@BethGriggs
test: clean up build files
35be08a 
Files generated by the build process were accidentally included as part
of an earlier commit. This removes them.

PR-URL: #28297
Reviewed-By: Beth Griggs <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Jul 17, 2019
Merged
@gabrielschulhof gabrielschulhof deleted the remove-superfluous-build-files branch October 27, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielschulhof @nodejs-github-bot @BethGriggs