tools: make pty_helper.py python3-compatible #29167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
|
I suppose the proper prefix is 'test:' because the script lives in test/pseudo-tty. It's invoked by tools/test.py though. |
|
Isn't covered by current tests, since they just do py2, but I did a |
sam-github
approved these changes
Aug 16, 2019
addaleax
approved these changes
Aug 16, 2019
63 tasks
Trott
approved these changes
Aug 18, 2019
Trott
added
the
author ready
|
Landed in 9c27118 |
Trott
pushed a commit
that referenced
this pull request
Aug 19, 2019
Fixes: #29166 PR-URL: #29167 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 20, 2019
Fixes: #29166 PR-URL: #29167 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #29166
cc @sam-github @cclauss