Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove replaceme placeholder #29853

Closed
wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

There seem to be quite a few CI failures looking like this:

TypeError: Cannot create property 'changes' on string 'REPLACEME'
14:15:34     at Object.extractAndParseYAML (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/doc/common.js:41:16)
14:15:34     at /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/doc/json.js:99:33
14:15:34     at Array.forEach (<anonymous>)
14:15:34     at doSection (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/doc/json.js:84:13)
14:15:34     at doSection (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/doc/json.js:200:9)
14:15:34     at doSection (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/doc/json.js:200:9)
14:15:34     at /data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/doc/json.js:58:7
14:15:34     at wrapped (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/doc/node_modules/trough/wrap.js:25:19)
14:15:34     at next (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/tools/doc/node_modules/trough/index.js:58:24)

This removes the only instance of REPLACEME I could find in the docs, to see if that fixes things.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Oct 5, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

Do you have a link to one of the failing CI failures? The REPLACEME placeholder is what should be in the YAML blocks until a release is made and the instance being replaced here is an example demonstrating such.

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not land, so just leaving a Request Changes here...

@Trott
Copy link
Member

Trott commented Oct 5, 2019

@Trott
Copy link
Member

Trott commented Oct 5, 2019

@richardlau An example is in https://ci.nodejs.org/job/node-test-commit-freebsd/28694/nodes=freebsd11-x64/console.

And the problem is in that PR. I'll comment there.

@Trott
Copy link
Member

Trott commented Oct 5, 2019

https://github.com/nodejs/node/pull/29737/files#r331761020

I'm going to close this PR.

@Trott Trott closed this Oct 5, 2019
@guybedford guybedford deleted the remove-replaceme branch October 5, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants